Merge pull request #18861 from ncounter/refactoring-click-popover-click

Refactoring workflow run list view

Author: ncounter

src/api/app/components/workflow_run_row_component.html.haml

@@ -1,19 +1,22 @@
-.col-auto.text-start
-  %i{ title: status_title, class: status_icon }
-.col.text-start
-  = link_to "#{hook_event.humanize} event", token_workflow_run_path(token_id, workflow_run)
-  - if hook_action
-    %span.ms-2.badge.text-bg-primary= hook_action.humanize
-.col.text-start
-  - if event_source_name
-    - popover_content = render partial: 'webui/workflow_runs/event_links', locals: { hook_event: hook_event,
-                                                                                     formatted_event_source_name: formatted_event_source_name,
-                                                                                     event_source_name: event_source_name,
-                                                                                     event_source_url: event_source_url }
-    = link_to formatted_event_source_name, 'javascript:;', { class: 'link-secondary', tabindex: '0',
-                                                             data: { 'bs-toggle': 'popover', 'bs-html': 'true', 'bs-trigger': 'focus',
-                                                                     'bs-content': popover_content } }
-  - else
-    Unknown source
-.col.text-end
-  = workflow_run.created_at
+.list-group-item.list-group-item-action
+  .row.flex-nowrap
+    .col-auto
+      %i{ title: status_title, class: status_icon }
+    .col.col-with-icon
+      .d-flex.justify-content-between
+        .px-1
+          = link_to "#{hook_event.humanize} event:", token_workflow_run_path(token_id, workflow_run)
+          - if hook_action
+            %strong= hook_action.humanize
+          %span= formatted_event_source_name || "Unknown source"
+          %span
+            - if event_source_name
+              - field_to_filter_by = hook_event.in?(['pull_request', 'Merge Request Hook']) ? 'pr_mr' : 'commit_sha'
+              = link_to event_source_url, { class: 'link-secondary mx-1',
+                                            title: "Go to Event Source #{formatted_event_source_name}",
+                                            target: '_blank' } do
+                %i.fa.fa-xs.fa-link.text-secondary
+              = link_to "?#{field_to_filter_by}=#{event_source_name}", { class: 'link-secondary mx-1', title: "Filter by this Event Source" } do
+                %i.fa.fa-xs.fa-filter.text-secondary
+        .px-1
+          %span= workflow_run.created_at

src/api/app/views/webui/workflow_runs/_event_links.html.haml

@@ -21,10 +21,8 @@
         - else
           .text-center
             %span.ms-3= page_entries_info(@workflow_runs)
-          .pt-3#workflow-runs
+          .p-3#workflow-runs
             - @workflow_runs.each do |workflow_run|
               .border-bottom.py-2{ id: "workflow-run-heading#{workflow_run.id}" }
-                .mb-0
-                  .row
-                    = render(WorkflowRunRowComponent.new(workflow_run: workflow_run, token_id: @token.id))
+                = render(WorkflowRunRowComponent.new(workflow_run: workflow_run, token_id: @token.id))
             = paginate @workflow_runs, views_prefix: 'webui'