Check the scmsync feature toggle in the scmsync checker concern

Author: hellcp-work

src/api/app/controllers/concerns/scmsync_checker.rb

@@ -4,6 +4,7 @@ module ScmsyncChecker
   extend ActiveSupport::Concern
 
   def check_scmsync
+    return if Flipper.enabled?(:scmsync, User.session)
     return if @project&.scmsync.blank?
 
     flash[:error] = "The project #{@project.name} is configured through scmsync. This is not supported by the OBS frontend"

src/api/app/controllers/webui/package_controller.rb

@@ -16,8 +16,7 @@ class Webui::PackageController < Webui::WebuiController
                                        save_person save_group remove_role view_file
                                        buildresult rpmlint_result rpmlint_log rpmlint_summary files]
 
-  before_action :check_scmsync, only: %i[statistics users requests revisions],
-                                unless: -> { action_name.in?(%w[users revisions]) && Flipper.enabled?(:scmsync, User.session) }
+  before_action :check_scmsync, only: %i[statistics users requests revisions]
 
   before_action :set_package, only: %i[edit update show requests statistics revisions
                                        branch_diff_info rdiff remove

src/api/app/controllers/webui/packages/binaries_controller.rb

@@ -12,7 +12,7 @@ class BinariesController < Webui::WebuiController
 
       before_action :require_login, except: [:index]
       before_action :set_project
-      before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :check_scmsync
       before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_multibuild_flavor

src/api/app/controllers/webui/packages/build_reason_controller.rb

@@ -4,7 +4,7 @@ class BuildReasonController < Webui::WebuiController
       include ScmsyncChecker
 
       before_action :set_project
-      before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :check_scmsync
       before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_repository

src/api/app/controllers/webui/packages/files_controller.rb

@@ -5,7 +5,7 @@ class FilesController < Webui::WebuiController
       include ScmsyncChecker
 
       before_action :set_project
-      before_action :check_scmsync, only: :show, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :check_scmsync, only: :show
       before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_filename, only: %i[show update destroy blame]

src/api/app/controllers/webui/packages/job_history_controller.rb

@@ -4,7 +4,7 @@ class JobHistoryController < Webui::WebuiController
       include ScmsyncChecker
 
       before_action :set_project
-      before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :check_scmsync
       before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_repository

src/api/app/controllers/webui/packages/meta_controller.rb

@@ -7,7 +7,7 @@ class MetaController < Webui::WebuiController
       before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
 
-      before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :check_scmsync
       before_action :validate_xml, only: :update
       before_action :check_sourceaccess, only: :update
       before_action :changed_project, only: :update

src/api/app/controllers/webui/repositories_controller.rb

@@ -2,7 +2,7 @@ class Webui::RepositoriesController < Webui::WebuiController
   include ScmsyncChecker
 
   before_action :set_project
-  before_action :check_scmsync, if: -> { params[:package] && !Flipper.enabled?(:scmsync, User.session) }
+  before_action :check_scmsync, if: -> { params[:package] }
   before_action :set_repository, only: %i[state mark_important]
   before_action :set_architectures, only: %i[index change_flag]
   before_action :set_package, only: %i[index change_flag], if: -> { params[:package] && !Flipper.enabled?(:scmsync, User.session) }