List all request actions into a separated tab page

Author: ncounter

src/api/app/components/bs_request_description_component.html.haml renamed to src/api/app/components/bs_request_actions_component.html.haml

@@ -1,6 +1,6 @@
 # This component renders the request description based on the type of the actions
 
-class BsRequestDescriptionComponent < ApplicationComponent
+class BsRequestActionsComponent < ApplicationComponent
   attr_reader :bs_request, :types
 
   def initialize(bs_request:)

src/api/app/components/bs_request_description_component.rb renamed to src/api/app/components/bs_request_actions_component.rb

@@ -7,28 +7,28 @@ class Webui::RequestController < Webui::WebuiController
 
   before_action :require_login,
                 except: %i[show beta_show sourcediff diff request_action request_action_changes request_action_details inline_comment build_results
-                           changes changes_diff mentioned_issues chart_build_results complete_build_results]
+                           changes changes_diff mentioned_issues chart_build_results complete_build_results request_actions]
   # requests do not really add much value for our page rank :)
   before_action :lockout_spiders
   before_action :require_request,
                 only: %i[changerequest show beta_show request_action request_action_changes request_action_details inline_comment build_results
-                         changes changes_diff mentioned_issues chart_build_results complete_build_results]
-  before_action :set_actions, only: %i[inline_comment beta_show build_results changes changes_diff mentioned_issues chart_build_results complete_build_results request_action_changes request_action_details],
+                         changes changes_diff mentioned_issues chart_build_results complete_build_results request_actions]
+  before_action :set_actions, only: %i[inline_comment beta_show build_results changes changes_diff mentioned_issues chart_build_results complete_build_results request_action_changes request_action_details request_actions],
                               if: -> { Flipper.enabled?(:request_show_redesign, User.possibly_nobody) }
   before_action :set_actions_deprecated, only: [:show]
   before_action :set_action, only: %i[inline_comment beta_show build_results changes changes_diff mentioned_issues request_action_details request_action_changes],
                              if: -> { Flipper.enabled?(:request_show_redesign, User.possibly_nobody) }
-  before_action :set_influxdb_data_request_actions, only: %i[beta_show build_results changes changes_diff mentioned_issues],
+  before_action :set_influxdb_data_request_actions, only: %i[beta_show build_results changes changes_diff mentioned_issues request_actions],
                                                     if: -> { Flipper.enabled?(:request_show_redesign, User.possibly_nobody) }
-  before_action :set_superseded_request, only: %i[show beta_show request_action request_action_changes build_results changes changes_diff mentioned_issues]
+  before_action :set_superseded_request, only: %i[show beta_show request_action request_action_changes build_results changes changes_diff mentioned_issues request_actions]
   before_action :check_ajax, only: :sourcediff
-  before_action :prepare_request_data, only: %i[beta_show build_results changes mentioned_issues],
+  before_action :prepare_request_data, only: %i[beta_show build_results changes mentioned_issues request_actions],
                                        if: -> { Flipper.enabled?(:request_show_redesign, User.possibly_nobody) }
-  before_action :prepare_request_header_data, only: %i[beta_show build_results changes mentioned_issues],
+  before_action :prepare_request_header_data, only: %i[beta_show build_results changes mentioned_issues request_actions],
                                               if: -> { Flipper.enabled?(:request_show_redesign, User.possibly_nobody) }
   before_action :cache_diff_data, only: %i[changes request_action_changes],
                                   if: -> { Flipper.enabled?(:request_show_redesign, User.possibly_nobody) }
-  before_action :check_beta_user_redirect, only: %i[beta_show build_results changes mentioned_issues changes_diff]
+  before_action :check_beta_user_redirect, only: %i[beta_show build_results changes mentioned_issues changes_diff request_actions]
 
   after_action :verify_authorized, only: [:create]
 
@@ -331,6 +331,10 @@ def build_results
     @buildable = @action.source_package || @project
   end
 
+  def request_actions
+    @active_tab = 'actions'
+  end
+
   def changes
     @active_tab = 'changes'
   end

src/api/app/controllers/webui/request_controller.rb

@@ -19,7 +19,7 @@
                                           current_object: bs_request)
 
 -# author + datetime + (if superseding -> "Superseds something")
-.card-text.px-4.pb-4
+.card-text.px-4
   %p.fst-italic
     Created by
     = user_with_realname_and_icon(bs_request.creator)
@@ -70,10 +70,6 @@
         This is a
         %mark.text-light.bg-maintenance.text-nowrap.text Maintenance Release
         request
-  .mt-4
-    %h5.mt-4
-      Actions
-    = render BsRequestDescriptionComponent.new(bs_request:)
   - if Flipper.enabled?(:labels, User.session)
     .mt-4
       = render partial: 'webui/shared/label', collection: bs_request.labels, as: :label

src/api/app/views/webui/request/_request_header.html.haml

@@ -7,6 +7,9 @@
       %li.nav-item.scrollable-tab-link.active
         = link_to('Build Results', request_build_results_path(bs_request.number),
                   class: "nav-link text-nowrap #{active_tab == 'build_results' ? 'active' : ''}")
+    %li.nav-item.scrollable-tab-link
+      = link_to('Actions', request_actions_path(bs_request.number),
+                class: "nav-link text-nowrap #{active_tab == 'actions' ? 'active' : ''}")
     %li.nav-item.scrollable-tab-link
       = link_to(request_changes_path(bs_request.number, actions_count > 1 ? action : nil),
                 class: "nav-link text-nowrap #{active_tab == 'changes' ? 'active' : ''}") do

src/api/app/views/webui/request/_request_tabs.html.haml

@@ -0,0 +1,19 @@
+:ruby
+  @pagetitle = "Request #{@bs_request.number}: #{@action.name}"
+
+.card
+  .card-body.p-0
+    = render partial: 'request_header',
+        locals: { bs_request: @bs_request, staging_status: @staging_status, action: @action,
+                  prev_action: @prev_action, next_action: @next_action, actions: @actions,
+                  diff_to_superseded_id: @diff_to_superseded_id, page_name: 'request_mentioned_issues',
+                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects,
+                  current_notification: @current_notification }
+    = render partial: 'request_tabs',
+        locals: { bs_request: @bs_request, action: @action, issues: @issues,
+                  actions_count: @actions.count, active_tab: @active_tab }
+
+    .container.p-4
+      %h5
+        Actions
+      = render BsRequestActionsComponent.new(bs_request: @bs_request)

src/api/app/views/webui/request/request_actions.html.haml

@@ -326,6 +326,7 @@
     # We can't apply the filename constraint, it prevents the use of `/` in file names.
     get 'requests/:number/actions/:request_action_id/changes/*filename' => :changes_diff, as: 'request_changes_diff', format: false, constraints: cons.except(:filename)
     get 'requests/:number/(actions/:request_action_id)/mentioned_issues' => :mentioned_issues, as: 'request_mentioned_issues', constraints: cons
+    get 'requests/:number/(actions/:request_action_id)/actions' => :request_actions, as: 'request_actions', constraints: cons
     post 'request/sourcediff' => :sourcediff
     post 'request/changerequest' => :changerequest
     get 'request/diff/:number' => :diff

src/api/config/routes/webui.rb

@@ -1,22 +1,22 @@
-class BsRequestDescriptionComponentPreview < ViewComponent::Preview
-  # Previews at http://HOST:PORT/rails/view_components/bs_request_description_component
+class BsRequestActionsComponentPreview < ViewComponent::Preview
+  # Previews at http://HOST:PORT/rails/view_components/bs_request_actions_component
   def submit_preview
     bs_request = BsRequestAction.where(type: :submit).last.bs_request
-    render(BsRequestDescriptionComponent.new(bs_request: bs_request))
+    render(BsRequestActionsComponent.new(bs_request: bs_request))
   end
 
   def delete_preview
     bs_request = BsRequestAction.where(type: :delete).last.bs_request
-    render(BsRequestDescriptionComponent.new(bs_request: bs_request))
+    render(BsRequestActionsComponent.new(bs_request: bs_request))
   end
 
   def add_role_preview
     bs_request = BsRequestAction.where(type: :add_role).last.bs_request
-    render(BsRequestDescriptionComponent.new(bs_request: bs_request))
+    render(BsRequestActionsComponent.new(bs_request: bs_request))
   end
 
   def change_devel_preview
     bs_request = BsRequestAction.where(type: :change_devel).last.bs_request
-    render(BsRequestDescriptionComponent.new(bs_request: bs_request))
+    render(BsRequestActionsComponent.new(bs_request: bs_request))
   end
 end