Improve the way the beta is checked

Author: hellcp-work

src/api/app/controllers/webui/package_controller.rb

@@ -16,8 +16,8 @@ class Webui::PackageController < Webui::WebuiController
                                        save_person save_group remove_role view_file
                                        buildresult rpmlint_result rpmlint_log rpmlint_summary files]
 
-  before_action :check_scmsync, only: %i[statistics requests]
-  before_action :check_scmsync, only: %i[users revisions], unless: -> { Flipper.enabled?(:scmsync, User.session) }
+  before_action :check_scmsync, only: %i[statistics users requests revisions],
+                                unless: -> { action_name.in?(%w[users revisions]) && Flipper.enabled?(:scmsync, User.session) }
 
   before_action :set_package, only: %i[edit update show requests statistics revisions
                                        branch_diff_info rdiff remove

src/api/app/controllers/webui/webui_controller.rb

@@ -101,7 +101,9 @@ def set_package
     return if @package_name.blank?
 
     begin
-      @package = Package.get_by_project_and_name(@project.name, @package_name, follow_multibuild: true, follow_project_scmsync_links: true)
+      @package = Package.get_by_project_and_name(@project.name, @package_name,
+                                                 follow_multibuild: true,
+                                                 follow_project_scmsync_links: Flipper.enabled?(:scmsync, User.session))
     # why it's not found is of no concern
     rescue APIError
       raise Package::UnknownObjectError, "Package not found: #{@project.name}/#{@package_name}"

src/api/app/models/project.rb

@@ -420,7 +420,7 @@ def very_important_projects_with_categories
     # class_methods
   end
 
-  def backend_packages
+  def backend_only_packages
     Nokogiri::XML(Backend::Api::Search.packages_for_project(name)).xpath('//package').map do |package|
       Package.get_by_project_and_name(name, package['name'], follow_multibuild: true, follow_project_scmsync_links: true)
     end

src/api/app/policies/assignment_policy.rb

@@ -3,7 +3,6 @@
 # checked as Assignment model validation.
 class AssignmentPolicy < ApplicationPolicy
   def create?
-    return false if record.package.readonly?
     return false unless Flipper.enabled?(:foster_collaboration, user)
 
     return true if user.admin?

src/api/app/views/webui/package/_tabs.html.haml

@@ -10,13 +10,15 @@
       - if Flipper.enabled?(:request_show_redesign, User.session)
         = tab_link('RPM Lint', rpmlint_result_path(project, package), 'scrollable-tab-link')
       = tab_link('Revisions', package_view_revisions_path(project, package), 'scrollable-tab-link')
-      - if Flipper.enabled?(:request_index, User.session)
-        = tab_link('Requests', packages_requests_path(project,
-                                                      package,
-                                                      state: %w[new review]),
-                               'scrollable-tab-link', active: controller_name == 'bs_requests')
-      - else
-        = tab_link('Requests', package_requests_path(project, package), 'scrollable-tab-link')
+      - unless package.readonly?
+        - if Flipper.enabled?(:request_index, User.session)
+          = tab_link('Requests', packages_requests_path(project,
+                                                        package,
+                                                        state: %w[new review]),
+                                 'scrollable-tab-link', active: controller_name == 'bs_requests')
+        - else
+          = tab_link('Requests', package_requests_path(project, package), 'scrollable-tab-link')
       = tab_link('Users', package_users_path(project, package), 'scrollable-tab-link')
-      = tab_link('Attributes', index_attribs_path(project, package), 'scrollable-tab-link')
+      - unless package.readonly?
+        = tab_link('Attributes', index_attribs_path(project, package), 'scrollable-tab-link')
       = tab_link('Meta', project_package_meta_path(project, package), 'scrollable-tab-link')

src/api/app/views/webui/package/side_links/_assignments.html.haml

@@ -8,7 +8,7 @@
       %p.mb-0.link-danger
         %i.fas.fa-user-minus
         Unassign
-- elsif policy(Assignment.new(package: package, assigner: User.session!)).create?
+- elsif !package.readonly?
   .dropdown#assignment-search
     %button.btn.btn-sm.dropdown-toggle.ps-0.border-0{ data: { 'bs-toggle': 'dropdown', 'bs-auto-close': 'outside' }, aria: { expanded: 'false' } }
       %strong

src/api/app/views/webui/project/_project_packages.html.haml

@@ -14,7 +14,7 @@
             %th Name
             %th SCM
         %tbody
-          - project.backend_packages.each do |package|
+          - project.backend_only_packages.each do |package|
             %tr
               %td
                 = link_to(package.name, package_show_path(project, package.name))

src/api/app/views/webui/project/show.html.haml

@@ -46,7 +46,7 @@
             Packages
             %span.badge.text-bg-primary
               - if @project.scmsync.present? && Flipper.enabled?(:scmsync, User.session)
-                = @project.backend_packages.count
+                = @project.backend_only_packages.count
               - else
                 = @packages.length
         - if @inherited_packages.present?