timeline.timer runs even if no timeline configured

[lnussel]

looking at my journal logs, snapper-timeline.timer activates every hour leaving a log entry even though /etc/snapper/configs/root has TIMELINE_CREATE="no".

How about not enabling the timer by default? Alternatively a generator could enable it at runtime during boot if a config has TIMELINE_CREATE=yes only.

[aschnell]

ARAIS at least for SUSE systemd services are only enabled if listed in the presets. So the timeline service could be disabled for specific products.

The solution with a generator looks a bit strange to me. It would likely be better if snapper (or snapperd) can enable and start the services depending on the configuration. That is not a tiny task and should also be reviewed by the security team.

[aschnell]

I have added code to enable the snapper-timeline.timer when setting TIMELINE_CREATE=yes or when creating a new config with TIMELINE_CREATE=yes. Code to disable the timer is not included.

Anyway, with that change we should be able to disable the timer per default on all SUSE product (assuming all have TIMELINE_CREATE=no).