Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolus ack is incorrect #4

Open
kenstack opened this issue Sep 12, 2016 · 1 comment
Open

bolus ack is incorrect #4

kenstack opened this issue Sep 12, 2016 · 1 comment

Comments

@kenstack
Copy link
Contributor

when bolusing the command is received but the ack response is incorrect

{'recieved': False, '_type': 'BolusRequest'}

I believe line 478 of commands.py is incorrect
received = True if self.data[0] is 0x0c else False

I think it should be similar to the basal ack 
received = True if (len(self.data) > 0 and self.data[0] is 0) else False

but I dont know enough about the data being received to verify, and it looks from the bolus ack that the 0x0c was not unintentional, so I cant be sure
@bewest
Copy link
Member

bewest commented Oct 27, 2016

Linked to this: oskarpearson/mmeowlink#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants