Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling DHCPv6 is disabling SLAAC also #76

Open
swe12345 opened this issue Oct 18, 2024 · 8 comments
Open

Disabling DHCPv6 is disabling SLAAC also #76

swe12345 opened this issue Oct 18, 2024 · 8 comments

Comments

@swe12345
Copy link

Disabling DHCPv6 is disabling SLAAC also

Disabling DHCPv6
curl -k -H "Content-Type: application/json" -H "X-Auth-Token: ${bmc_token}" -X PATCH -d '{"DHCPv6": {"OperatingMode" : "Disabled"}}' https://$bmc/refish/v1/Managers/bmc/EthernetInterfaces/eth1

Seeing that
IPv6AutoConfigEnabled in eth1 is being set to False

@swe12345
Copy link
Author

@ratagupt @williamspatrick

@williamspatrick
Copy link
Member

Not sure why I am tagged here.

@mdmillerii
Copy link

Was it enabled before your patch? Was it in the network configuration file?

Search ipv6AcceptRa in https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/ethernet.hpp#L1143 to see how it's translated from redfish to dbus and this search in phosphor networkd https://github.com/search?q=repo%3Aopenbmc%2Fphosphor-networkd%20IPv6AcceptRA&type=code

@prkatti1
Copy link

DHCPv6 has dependency on SLAAC as it does not provide default gateway.
SLAAC has no dependency on DHCPv6.
I think @swe12345 is trying following scenario:
Pre-condition: When SLAAC is enabled & DHCPv6 is enabled, if user disables DHCPv6, it is disabling SLAAC also.

@mdmillerii
Copy link

The request was to actually verify it was reported and recognized to help isolate which components need to changed.

@prkatti1
Copy link

Submitter is expecting, if DHCPv6 is disabled it should disable only DHCPv6 and not other functions.
Fix is required in Redfish DHCPv6 disable function

@chaul-ampere
Copy link

Submitter is expecting, if DHCPv6 is disabled it should disable only DHCPv6 and not other functions. Fix is required in Redfish DHCPv6 disable function

bmcweb sets DHCPEnabled property on DBus as DHCPv6/OperatingMode is set (https://github.com/openbmc/bmcweb/blob/02ea923f13de196726ac2f022766a6f80bee1c0a/redfish-core/lib/ethernet.hpp#L1445). I guess in the scenario of the submitter, DHCPEnabled did not fall on any of these conditions (

auto newra = EthernetInterfaceIntf::ipv6AcceptRA(
), so ipv6AcceptRA was set to false as a result. Correct me if I'm wrong.

@raviteja-b
Copy link
Contributor

Not sure why I am tagged here.

I think she wanted to tag @wak-google

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants