Skip to content

remove key_prefix from time features #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AUdaltsova opened this issue Feb 7, 2025 · 8 comments · May be fixed by #222
Open

remove key_prefix from time features #159

AUdaltsova opened this issue Feb 7, 2025 · 8 comments · May be fixed by #222
Assignees
@Dakshbir
Labels
contributions-welcome Good issues for open-source contribution

Comments

@AUdaltsova
Copy link
Contributor

time features currently use key_prefix, which was needed for ocf_datapipes but is not anymore and should be removed for clarity
@anxkhn anxkhn mentioned this issue Feb 9, 2025
Closed
5 tasks
@chaitanya-rdY
Copy link
Contributor

@AUdaltsova, I'd like to work on this issue. Could you please assign it to me?

@Sukh-P
Copy link
Member

Sukh-P commented Feb 12, 2025 •
edited
Loading

@chaitanya-rdY sorry I can see that @anxkhn already made a PR for this so I'll assign them to this issue

@AUdaltsova AUdaltsova added the contributions-welcome Good issues for open-source contribution label Feb 18, 2025
@ayushraj09
Copy link

@Sukh-P @AUdaltsova

I would be glad to assist in resolving this issue. Could you please provide an update on the current status? If no progress has been made, I am ready to begin working on it.

Looking forward to your response.

@AUdaltsova
Copy link
Contributor Author

Hi @ayushraj09, sorry it took so long to get back to you! Since the previous PR on this has been dropped, I can assign you to this issue if you still up for doing it. Please let me know if you still want to be assigned.

@Dakshbir
Copy link

@AUdaltsova Sir am up for this issue!
Could you assign this to me?

@AUdaltsova
Copy link
Contributor Author

Hi @Dakshbir, yeah sure! Thanks for volunteering. You can see the previous PR for reference, as it was on the right track!

@Dakshbir Dakshbir linked a pull request Apr 1, 2025 that will close this issue
Open
@Dakshbir
Copy link

Dakshbir commented Apr 1, 2025

@AUdaltsova hello sir
Sir I have raised a PR #222
Kindly review it. I hope it solves the issue :)

@Dakshbir
Copy link

Dakshbir commented Apr 6, 2025

@AUdaltsova Sir just a gentle reminder to review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dakshbir Dakshbir

Labels
contributions-welcome Good issues for open-source contribution
Projects
None yet
Milestone
No milestone
5 participants
@Sukh-P @AUdaltsova @ayushraj09 @Dakshbir @chaitanya-rdY