Skip to content

Validate accum_channels is a subset of channels in config model #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AUdaltsova opened this issue Apr 15, 2025 · 5 comments · May be fixed by #241
Open

Validate accum_channels is a subset of channels in config model #236

AUdaltsova opened this issue Apr 15, 2025 · 5 comments · May be fixed by #241
Assignees
@RupeshMangalam21
Labels
contributions-welcome Good issues for open-source contribution good first issue Good for newcomers

Comments

@AUdaltsova
Copy link
Contributor

We expect accum_channels to be a subset of channels for any NWP source: after loading we select only channels, so if something is in accum_channels but not in channels, it will have no data to diff. I think we should validate that in the config.

Solution:
Add a validation function to the NWP class in the config that checks that what is passed to accum_channels is a subset of what is passed to channels.
@AUdaltsova AUdaltsova added good first issue Good for newcomers contributions-welcome Good issues for open-source contribution labels Apr 15, 2025
@RupeshMangalam21
Copy link
Contributor

Hi, @AUdaltsova I would like to help with this!

@AUdaltsova
Copy link
Contributor Author

Hi @RupeshMangalam21, that'd be great, thanks! Assigned you

@lambaaryan011
Copy link

Hi @RupeshMangalam21, are you work on this or need any help.

@lambaaryan011
Copy link

Hi @AUdaltsova can I take over this issue. If @RupeshMangalam21 is not working .

@RupeshMangalam21
Copy link
Contributor

Hi @RupeshMangalam21, are you work on this or need any help.

I am working on it. Thanks for offering help

@RupeshMangalam21 RupeshMangalam21 linked a pull request Apr 20, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RupeshMangalam21 RupeshMangalam21

Labels
contributions-welcome Good issues for open-source contribution good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate channels RupeshMangalam21/ocf-data-sampler
3 participants
@AUdaltsova @RupeshMangalam21 @lambaaryan011