Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transferToRemote RPC has misleading comments #115

Open
RonanMacF opened this issue Feb 7, 2023 · 0 comments
Open

transferToRemote RPC has misleading comments #115

RonanMacF opened this issue Feb 7, 2023 · 0 comments

Comments

@RonanMacF
Copy link

https://github.com/openconfig/gnoi/blob/main/file/file.proto#L36 mentions

  // TransferToRemote transfers the contents of a file from the target to a
  // specified remote location.

This makes sense.

https://github.com/openconfig/gnoi/blob/main/file/file.proto#L116 mentions

// A TransferToRemoteRequest specifies the local path to transfer to and the
// details on where to transfer the data from. The local_path must be an
// absolute path to the file.
message TransferToRemoteRequest {
  string local_path = 1;

  // Details to download the remote_file being requested to a remote location.
  gnoi.common.RemoteDownload remote_download = 2;
}

I don;t think this is right, this seems to be describing a transferFromRemote RPC which doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant