Skip to content

Fix deprecated and missing props in TablePagination #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andoriyaprashant
Copy link

What does this PR change?

  • Updates deprecated props onChangePage and onChangeRowsPerPage to onPageChange and onRowsPerPageChange in TablePagination components.
  • Fixes missing required prop onPageChange that caused console warnings.

Does this PR relate to any other PRs?

  • No direct relation to other PRs.

How will this PR impact users?

  • Eliminates console warning errors related to TablePagination usage, improving developer experience and code compatibility with Material UI v5.

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

  • Manually debugged and ran the UI components in allocationReport.js, cloudCost.js, and externalCostsTable.js to verify pagination works correctly without console errors.

Does this PR require changes to documentation?

  • No

Copy link

netlify bot commented May 16, 2025

Deploy Preview for opencost-ui ready!

Name Link
🔨 Latest commit 56121e8
🔍 Latest deploy log https://app.netlify.com/projects/opencost-ui/deploys/6838c0923845bb00082f3d1f
😎 Deploy Preview https://deploy-preview-84--opencost-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmello
Copy link
Member

lmello commented May 29, 2025

thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated and missing props in TablePagination component
2 participants