UmountFs will cause deadlock

[surpassly]

Describe the bug (描述bug)
UmountFs will cause deadlock

To Reproduce (复现方法)
Deadlock happens in this circumstances.
A and B are different mount points of same Fs.

1. A acquires NameLockGuard in UmountFs
2. B acquires WriteLockGuard in UpdateClientAliveTime
3. B acquires NameLockGuard in AddMountPoint
4. A acquires WriteLockGuard in DeleteClientAliveTime

Expected behavior (期望行为)

Versions (各种版本)
OS:
Compiler:
branch:
commit id:

Additional context/screenshots (更多上下文/截图)

[wuhongsong]

@surpassly thanks for you contribution. @SeanHai have a look？

[surpassly]

这是来自QQ邮箱的自动回复邮件。

[zhanghuidinah]

• This issue has been chosen for community developer activities. Welcome to feel free to try it. After the PR is merged, you will receive a gift package and a certificate as a community contributor.

• Developer Activities Registration Steps please ref [2023 Q2 Developer Activities]: Call For Participation！ #2334 (comment)

[liuxy028]

Hello, I want to solve this porblem!

[liuxy028]

ok   刘习永 ***@***.***  

…

------------------ 原始邮件 ------------------ 发件人: "Hui ***@***.***>; 发送时间: 2023年4月21日(星期五) 上午9:44 收件人: ***@***.***>; 抄送: ***@***.***>; ***@***.***>; 主题: Re: [opencurve/curve] UmountFs will cause deadlock (Issue #2308) ***@***.*** — 直接回复这封邮件，在GitHub上查看或取消订阅. ***@***.***与>.

[liuxy028]

Sorry, it's too difficult. I'm still studying and I'm afraid I can't solve it. I am about to start my final exam recently, and I want to give up. I'm really sorry  刘习永 ***@***.***  

…

------------------ 原始邮件 ------------------ 发件人: ***@***.***>; 发送时间: 2023年4月27日(星期四) 上午10:24 收件人: ***@***.***>; 抄送: ***@***.***>; ***@***.***>; 主题: Re: [opencurve/curve] UmountFs will cause deadlock (Issue #2308) @liuxy028 how is going on? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Xinlong-Chen]

I don't find the code about add NameLockGuard in AddMountPoint.

curve/curvefs/src/mds/fs_manager.cpp

Lines 1060 to 1085 in a713551

	FSStatusCode FsManager::AddMountPoint(const Mountpoint& mountpoint,
	const std::string& fsName) {
	LOG(INFO) << "AddMountPoint mountpoint = " << mountpoint.DebugString()
	<< ", fsName = " << fsName;
	// 1. query fs
	FsInfoWrapper wrapper;
	FSStatusCode ret = fsStorage_->Get(fsName, &wrapper);
	if (ret != FSStatusCode::OK) {
	LOG(WARNING) << "AddMountPoint fail, get fs fail, fsName = " << fsName
	<< ", errCode = " << FSStatusCode_Name(ret);
	return ret;
	}
	// 2. insert mountpoint
	wrapper.AddMountPoint(mountpoint);
	// for persistence consider
	ret = fsStorage_->Update(wrapper);
	if (ret != FSStatusCode::OK) {
	LOG(WARNING) << "AddMountPoint update fs fail, fsName = " << fsName
	<< ", mountpoint = " << mountpoint.ShortDebugString()
	<< ", errCode = " << FSStatusCode_Name(ret);
	return ret;
	}
	return FSStatusCode::OK;
	}

Has the bug been fixed?

[surpassly]

这是来自QQ邮箱的自动回复邮件。