Editing the terms shouldn't throw alerts. (#1701)

opendatadiscovery · Sep 9, 2024 · 6650f1b · 6650f1b
1 parent d2172b4
commit 6650f1b
Showing 1 changed file with 15 additions and 10 deletions.
diff --git a/odd-platform-ui/src/components/Terms/TermSearch/TermForm/TermsForm.tsx b/odd-platform-ui/src/components/Terms/TermSearch/TermForm/TermsForm.tsx
@@ -80,18 +80,23 @@ const TermsForm: FC<TermsFormDialogProps> = ({ btnCreateEl }) => {
   };
 
   const onSubmit = (data: TermFormData) => {
-    const duplicateTerm = existingTerms.find(
-      (existingTerm: TermDetails) =>
-        existingTerm.name === data.name &&
-        existingTerm.namespace.name === data.namespaceName
-    );
-
-    if (duplicateTerm) {
-      setError('A term with the same name already exists in this namespace.');
-      return;
+    // Check if we're in create mode (no term.id present)
+    if (!term?.id) {
+      const duplicateTerm = existingTerms.find(
+        (existingTerm: TermDetails) =>
+          existingTerm.name === data.name &&
+          existingTerm.namespace.name === data.namespaceName
+      );
+
+      if (duplicateTerm) {
+        setError('A term with the same name already exists in this namespace.');
+        return;
+      }
     }
 
     const parsedData = { ...data };
+
+    // Determine whether to create or update the term
     (term && term.id
       ? dispatch(updateTerm({ termId: term.id, termFormData: parsedData }))
       : dispatch(createTerm({ termFormData: parsedData }))
@@ -210,4 +215,4 @@ const TermsForm: FC<TermsFormDialogProps> = ({ btnCreateEl }) => {
   );
 };
 
-export default TermsForm;
+export default TermsForm;