Skip to content

Add errors/warnings in the logs if metrics cannot be captured #79

@bdattoma

Description

@bdattoma

While testing, we noticed that is there is an issue with capturing the metrics which are exposed by kserve/caikit/istio, the odh-model-controller doesn't report any error or warning. It keeps printing out something like:

1.693903864744821e+09	INFO	controllers.InferenceService	Reconciling Metrics ServiceMonitor for InferenceSercvice	{"InferenceService": "<isvc_name>", "namespace": "<test_ns>"}
1.6939038647538376e+09	INFO	controllers.InferenceService	Metrics ServiceMonitor already exists for InferenceService	{"InferenceService": "<isvc_name>", "namespace": "<test_ns>"}

It would be helpful to have a line in the logs saying that there isn't something working fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Status

    New/Backlog

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions