Skip to content

Commit 8daa472

Browse files
authored
Fix ODS api service version (#1357)
* Add ODS_API_SERVICE_VERSION parameter to build configuration and Dockerfile * changelog
1 parent cffb33d commit 8daa472

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## Unreleased
44

55
### Added
6-
- New core component, OpenDevStack API service ([#1356](https://github.com/opendevstack/ods-core/pull/1356))
6+
- New core component, OpenDevStack API service ([#1356](https://github.com/opendevstack/ods-core/pull/1356)) & ([#1357](https://github.com/opendevstack/ods-core/pull/1357))
77

88
### Changed
99
- Change Cnes report to custom SonarQube report ([#1354](https://github.com/opendevstack/ods-core/pull/1354))

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ install-ods-api-service: start-ods-api-service-build apply-ods-api-service-chart
189189

190190
## Start build of BuildConfig "Ods API Service".
191191
start-ods-api-service-build:
192-
cd ods-api-service/build-config && oc process -f template.yaml -p ODS_NAMESPACE=$(ODS_NAMESPACE) -p ODS_IMAGE_TAG=$(ODS_IMAGE_TAG) -p BITBUCKET_URL=$(BITBUCKET_URL) -p ODS_BITBUCKET_PROJECT=$(ODS_BITBUCKET_PROJECT) -p ODS_GIT_REF=$(ODS_GIT_REF) | oc apply --namespace $(ODS_NAMESPACE) -f -
192+
cd ods-api-service/build-config && oc process -f template.yaml -p ODS_NAMESPACE=$(ODS_NAMESPACE) -p ODS_IMAGE_TAG=$(ODS_IMAGE_TAG) -p BITBUCKET_URL=$(BITBUCKET_URL) -p ODS_BITBUCKET_PROJECT=$(ODS_BITBUCKET_PROJECT) -p ODS_GIT_REF=$(ODS_GIT_REF) -p ODS_API_SERVICE_VERSION=$(ODS_API_SERVICE_VERSION) | oc apply --namespace $(ODS_NAMESPACE) -f -
193193
ocp-scripts/start-and-follow-build.sh --namespace $(ODS_NAMESPACE) --build-config ods-api-service
194194
.PHONY: start-ods-api-service-build
195195

configuration-sample/ods-core.ods-api-service.env.sample

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Global configuration for OpenDevStack Api Service #
33
#####################################################
44

5+
# OpenDevStack Api Service Version
6+
# See https://github.com/opendevstack/ods-api-service/releases
7+
ODS_API_SERVICE_VERSION=0.0.1
8+
59
# JVM configuration
610
JAVA_OPTS=-Xmx1g -Djavax.net.ssl.trustStore=/home/default/custom-truststore.jks -Djavax.net.ssl.trustStorePassword=changeit
711

ods-api-service/build-config/template.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ parameters:
2121
- name: ODS_GIT_REF
2222
description: "Git reference (branch or tag)"
2323
required: true
24-
- name: API_SERVICE_VERSION
24+
- name: ODS_API_SERVICE_VERSION
2525
description: "API Service version"
2626
required: false
2727
value: "latest"
@@ -72,8 +72,8 @@ objects:
7272
noCache: true
7373
forcePull: true
7474
buildArgs:
75-
- name: API_SERVICE_VERSION
76-
value: ${API_SERVICE_VERSION}
75+
- name: ODS_API_SERVICE_VERSION
76+
value: ${ODS_API_SERVICE_VERSION}
7777
postCommit: {}
7878
source:
7979
type: Git

ods-api-service/docker/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ FROM registry.access.redhat.com/ubi9/openjdk-21-runtime:latest
44
# This applies for version from 2.10 and not below.
55
ENV LOG4J_FORMAT_MSG_NO_LOOKUPS=true
66

7-
ARG API_SERVICE_VERSION=latest
7+
ARG ODS_API_SERVICE_VERSION=latest
88

9-
RUN curl -L https://github.com/opendevstack/ods-api-service/releases/download/$API_SERVICE_VERSION/app.jar -o app.jar
9+
RUN curl -L https://github.com/opendevstack/ods-api-service/releases/download/v$ODS_API_SERVICE_VERSION/app.jar -o app.jar
1010

1111
# Environment variable for certificate URLs (comma-separated) ENV CERT_URLS="" it is needed to install the certificates
1212
COPY install-certs.sh /opt/install-certs.sh

0 commit comments

Comments
 (0)