Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Updated java version check to fix dependency error #672

Conversation

JonahCalvo
Copy link

@JonahCalvo JonahCalvo commented Jun 18, 2021

Issue #, if available:
Issue #636
Current java type checking caused issues differentiating between Java 1.x and Java Version x

Description of changes:
Updated the bash script for installation to include regex that can handle both ways of reporting Java Version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@JonahCalvo JonahCalvo closed this Jun 18, 2021
@JonahCalvo JonahCalvo reopened this Jun 18, 2021
@JonahCalvo JonahCalvo linked an issue Jun 18, 2021 that may be closed by this pull request
@JonahCalvo JonahCalvo closed this Jun 18, 2021
@JonahCalvo JonahCalvo reopened this Jun 18, 2021
Copy link
Contributor

@wrijeff wrijeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wrijeff wrijeff requested a review from chenqi0805 June 29, 2021 15:52
@dlvenable dlvenable closed this Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup script fails with OpenJDK 1.8
4 participants