Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support direct-io for non-512 sector disk #40

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mchtech
Copy link

@mchtech mchtech commented Jan 3, 2025

fix: #39

upgrade baseos from buster to bookworm.

losetup from util-linux should include util-linux/util-linux@a1a4159 , in order to support dio for non-512 sector disk (4k sectors).

@tiagolobocastro
Copy link

Hi @mchtech @srkaviani @mhkarimi1383

Pinging you as you have made PR's recently on this repo.
First of all I would like to apologize for the lack of reviews here. Unfortunately the sub-project maintainer has not been active and has now state he not longer has time to maintain it (which tbh he hasn't been doing for a very long time). We are in the process of removing removing him as sub-project maintainer: openebs/community#174

The other maintainers have no time to take up maintaining this additional project.
With this comes a tough decision, we are considering archiving this project, unless someone from the community can help us.
Would any of you been open to help keep this project running?

Another option we've been discussing is to convert the other localpv driver (dynamic-localpv-provisioner) to a csi driver and add this functionality to it.

@mhkarimi1383
Copy link

@tiagolobocastro
Hi,
Thanks for the update

I have switched to LVM Local PV for my Local PV usages

I can work on this project but not as a maintainer, since my time is a bit limited too

@mhkarimi1383
Copy link

mhkarimi1383 commented Jan 18, 2025

@tiagolobocastro
I like the idea of this project, and I like to work on that, I can help this project as a maintainer if we could have multiple maintainers :), So I can't be the only one ;)

@srkaviani
Copy link

Hi, @tiagolobocastro

Thank you for reaching out and for your transparency regarding the status of this project. I am open to contributing to the development and maintenance of this project. However, I would like to note that this project is also being actively developed as a separate initiative by Canonical in this repository:
https://github.com/canonical/rawfile-localpv.

Please let me know how I can assist and collaborate effectively in this regard.

@tiagolobocastro
Copy link

@srkaviani thank you for bringing that our attention, we had no idea. I suspect they may have forked since there hasn't been any activity in this repo.

It'd be great if we could continue semekh's work here with the assistance from folks like both of you.
At the same time just 2 may not be enough as we had tried to resume this effort back in May but with no success: openebs/community#49

@addyess would you be able some insights on the fork and whether there's scope to combine efforts here.

Another way forward is what we had discussed previously, related to another effort which we have planned which is to rewrite the other hostpath as a CSI driver and also include this functionality within it, rather than keep two separate repos for quite similar functionality. To be honest this would be my preferred approach but would like to hear your thoughts here as well.

Thank you

CC @avishnu @niladrih

@srkaviani
Copy link

@tiagolobocastro
I have not yet found a suitable alternative to rawfile that offers all of its features.
For instance, most local CSI drivers do not support disk size limitations effectively.
This is why, despite the development of this project being halted, others have forked and continued its development.
Overall, I consider the rawfile project to be quite valuable.

If you also agree on continuing the development of this project, my colleagues and I could likely maintain and further develop it.

@tiagolobocastro
Copy link

disk size limitations effectively

Yeah, on the other hostpath driver only way to achieve is with quotas

If you also agree on continuing the development of this project, my colleagues and I could likely maintain and further develop it.

That would be great, and we'd be happy to provide with any help we can to get this going

Would you be able to join our community meeting on thursday 30th?
https://tockify.com/cncf.public.events/detail/837/1738245600000
Alternatively we can setup a ad-hoc google meet

@addyess
Copy link

addyess commented Jan 22, 2025

@tiagolobocastro

Hi, Canonical's fork of this is for its use as a local storage controller. We've really not made any adjustments to the python or even base image itself other than using a canonical tool called "rockcraft" to build the images.

I'll tag some others who might be interested in joining a discussion about maintainership

CC @ktsakalozos @claudiubelu

@mhkarimi1383
Copy link

@tiagolobocastro

Hi, Canonical's fork of this is for its use as a local storage controller. We've really not made any adjustments to the python or even base image itself other than using a canonical tool called "rockcraft" to build the images.

I'll tag some others who might be interested in joining a discussion about maintainership

CC @ktsakalozos @claudiubelu

I would love to be maintainers team too :)

@srkaviani
Copy link

Would you be able to join our community meeting on thursday 30th?

Yes I can. If you agree i can add some of my friends who that maybe they can contribute on this project.

@tiagolobocastro
Copy link

Would you be able to join our community meeting on thursday 30th?

Yes I can. If you agree i can add some of my friends who that maybe they can contribute on this project.

Yes ofcourse would be great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

direct-io does not enabled on 4k-sector disk
5 participants