Skip to content

Commit 3789d96

Browse files
author
Eric Fischer
authored
Merge pull request #1003 from edx/efischer/fix_tests
Fix file upload tests
2 parents cffda37 + 83a5da4 commit 3789d96

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

test/acceptance/pages.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def upload_file_button_is_enabled(self):
178178
Returns:
179179
bool
180180
"""
181-
return self.q(css="button.file__upload").attrs('disabled') == ['false']
181+
return self.q(css="button.file__upload")[0].is_enabled()
182182

183183
@property
184184
def upload_file_button_is_disabled(self):

test/acceptance/tests.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -741,18 +741,12 @@ def test_file_upload(self):
741741
self.assertTrue(self.submission_page.has_file_error)
742742

743743
# trying to upload a acceptable file
744-
readme1 = os.path.dirname(os.path.realpath(__file__)) + '/README.rst'
745-
readme2 = readme1.replace('test/acceptance/', '') # There's another README located at ../../
746-
747-
files = ', '.join([readme1, readme2])
748-
self.submission_page.visit().select_file(files)
744+
readme = os.path.dirname(os.path.realpath(__file__)) + '/README.rst'
745+
self.submission_page.visit().select_file(readme)
749746
self.assertFalse(self.submission_page.has_file_error)
750747
self.assertTrue(self.submission_page.upload_file_button_is_disabled)
751748

752749
self.submission_page.add_file_description(0, 'file description 1')
753-
self.assertTrue(self.submission_page.upload_file_button_is_disabled)
754-
755-
self.submission_page.add_file_description(1, 'file description 2')
756750
self.assertTrue(self.submission_page.upload_file_button_is_enabled)
757751

758752
self.submission_page.upload_file()

0 commit comments

Comments
 (0)