Skip to content

Commit 0baf71c

Browse files
authored
Merge pull request #34479 from DmytroAlipov/fix-transcript-replacement
fix: an issue where changing the transcript language code
2 parents 7ac03a2 + 911bf73 commit 0baf71c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

xmodule/video_block/video_handlers.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,7 @@ def validate_transcript_upload_data(self, data):
467467

468468
return error
469469

470+
# pylint: disable=too-many-statements
470471
@XBlock.handler
471472
def studio_transcript(self, request, dispatch):
472473
"""
@@ -534,6 +535,10 @@ def studio_transcript(self, request, dispatch):
534535
'edx_video_id': edx_video_id,
535536
'language_code': new_language_code
536537
}
538+
# If a new transcript is added, then both new_language_code and
539+
# language_code fields will have the same value.
540+
if language_code != new_language_code:
541+
self.transcripts.pop(language_code, None)
537542
self.transcripts[new_language_code] = f'{edx_video_id}-{new_language_code}.srt'
538543
response = Response(json.dumps(payload), status=201)
539544
except (TranscriptsGenerationException, UnicodeDecodeError):

0 commit comments

Comments
 (0)