Skip to content

Commit 25536bb

Browse files
authored
fix: downgrade karma-spec-reporter to fix JS test logging (#35954)
The karma-spec-reporter npm package is a Karma plugin which tells Karma to print the name of each spec (e.g. test case). This is extremely useful as a maintainer to be able to visually inspect the CI logs and confirm that we are actually running JS tests and not just giving false-positives. We are stuck on an ancient Karma version (0.13.22, lastest is 6.x), which seems to be incompatible with the latest karma-spec-reporter version (0.0.36). Since upgrading karma-spec-reporter, spec name printing has failed with: 02 12 2024 20:59:28.164:WARN [plugin]: Error during loading "karma-spec-reporter" plugin: Cannot read properties of undefined (reading 'LOG_PRIORITIES') Downgrading to [email protected] eliminates this error and restoring spec name printing to our JS CI logs.
1 parent 70b60ff commit 25536bb

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

.github/renovate.json5

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@
3232
// When adding an ignoreDep, please include a reason and a public link that we can use to follow up and ensure
3333
// that the ignoreDep is removed.
3434
// This can be done as a comment within the ignoreDeps list.
35-
"ignoreDeps": [],
35+
"ignoreDeps": [
36+
// karma-spec-reporter>0.20.0 does not seem compatible with our super-old 2016 Karma version (0.13.22).
37+
// Ticket link: None, as upgrading Karma does not strike as worth the benefit.
38+
"karma-spec-reporter"
39+
],
3640
"timezone": "America/New_York",
3741
"prConcurrentLimit": 3,
3842
"enabledManagers": ["npm"]

package-lock.json

Lines changed: 14 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
"karma-requirejs": "1.1.0",
104104
"karma-selenium-webdriver-launcher": "github:openedx/karma-selenium-webdriver-launcher#0.0.4-openedx.0",
105105
"karma-sourcemap-loader": "0.4.0",
106-
"karma-spec-reporter": "0.0.36",
106+
"karma-spec-reporter": "0.0.20",
107107
"karma-webpack": "^5.0.1",
108108
"plato": "1.7.0",
109109
"react-test-renderer": "16.14.0",

0 commit comments

Comments
 (0)