Closed
Conversation
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
7 times, most recently
from
c9ecb0e to
1042fd7
Compare
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
10 times, most recently
from
6f94e9a to
b86974e
Compare
UsamaSadiq
requested changes
Jan 16, 2025
| user_timezone_locale = user_timezone_locale_prefs(crum.get_current_request()) | ||
| user_timezone = timezone(user_timezone_locale['user_timezone'] or browser_timezone or str(UTC)) | ||
| return user_timezone.localize(datetime.now()) | ||
| user_timezone = ZoneInfo(user_timezone_locale['user_timezone'] or browser_timezone or "UTC") |
Member
There was a problem hiding this comment.
Is the ZoneInfo result already localized?
common/djangoapps/track/utils.py
Outdated
| except UnknownTimeZoneError as err: | ||
| return timezone('UTC') | ||
| return ZoneInfo(user_timezone) | ||
| except KeyError: |
Member
There was a problem hiding this comment.
Why not use UnknownZoneInfoError here as used in some files above?
openedx/features/content_type_gating/migrations/0003_auto_20181128_1407.py
Outdated
Show resolved
Hide resolved
openedx/features/content_type_gating/migrations/0004_auto_20181128_1521.py
Outdated
Show resolved
Hide resolved
openedx/features/course_duration_limits/migrations/0002_auto_20181119_0959.py
Outdated
Show resolved
Hide resolved
openedx/features/course_duration_limits/migrations/0003_auto_20181128_1407.py
Outdated
Show resolved
Hide resolved
openedx/features/course_duration_limits/migrations/0004_auto_20181128_1521.py
Outdated
Show resolved
Hide resolved
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
2 times, most recently
from
d3d735b to
18baec4
Compare
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
8 times, most recently
from
e94b717 to
2049a92
Compare
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
from
2049a92 to
683f53f
Compare
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
from
683f53f to
1db7f83
Compare
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
from
1db7f83 to
5d5160b
Compare
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
7 times, most recently
from
5967e80 to
9824eb3
Compare
mumarkhan999
force-pushed
the
umar/remove-pytz
branch
from
9824eb3 to
e37e2ec
Compare
Contributor
|
Closing this old out of date PR. Feel free to re-open after an update and tag me if it's still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The alternative of some methods and variables of pytz is not available in zoneinfo.
So currently we haven't been able to obliterate pytz. We are using them simultaneously.