Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react to v18 #1220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

huniafatima-99
Copy link
Contributor

@huniafatima-99 huniafatima-99 commented Mar 26, 2025

Description

This PR upgrades react to v18. It also updated the test cases to remove the deprecated approaches according to react 18.

How Has This Been Tested?

All the test suites were ran and they were successful. In addition, major functionalities are working when ran the MFE in the browser.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.50%. Comparing base (17e12f7) to head (285f45a).

Files with missing lines Patch % Lines
src/index.jsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   58.53%   58.50%   -0.03%     
==========================================
  Files         117      117              
  Lines        2320     2321       +1     
  Branches      639      641       +2     
==========================================
  Hits         1358     1358              
- Misses        901      902       +1     
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huniafatima-99 huniafatima-99 linked an issue Mar 26, 2025 that may be closed by this pull request
@huniafatima-99 huniafatima-99 self-assigned this Mar 26, 2025
@brian-smith-tcril
Copy link
Contributor

Thank you so much for opening this PR! The plan for the React 18 upgrades is to use StrictMode - would you be able to update this PR to do that?

https://react.dev/reference/react/StrictMode

@huniafatima-99
Copy link
Contributor Author

@brian-smith-tcril sure, let me update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 18 Upgrade
2 participants