Skip to content

feat: account level, email notification preferences and embargo feature #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 16, 2025

Conversation

awais-ansari
Copy link
Contributor

@awais-ansari awais-ansari commented Apr 13, 2025

INF-1772

Description

This PR is meant to remove branch divergence from the Account MFE. Currently deployed branches are 2u-main and the community is using the master branch. A PR has been created to shift the deployment pipeline to the default branch. 2u-main branch contains

  • Account level preferences
  • Email notification preferences
  • Embargo feature
  • Minor bug fixes

Test Plan

  • Test the changes on the master branch locally
  • Update the stage config file to shift the branch to master on the stage pipeline
  • test the features on stage env
  • Update the stage config file to shift the branch to master on the Production pipeline
  • Test the change on production env

awais-ansari and others added 18 commits April 15, 2025 14:10
* feat: added country disabling feature

* refactor: removed isDisabledCountry additional call
* fix: fixed support urls (#1155)

* fix(deps): update dependency @edx/frontend-component-header to v5.7.1 (#1156)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @openedx/frontend-slot-footer to v1.0.6 (#1157)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: fixed certificates url

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: added notification preferences settings at account level

* fix: fixed test cases

* feat: added api for account notification type

* fix: fixed test cases and label

* test: added update account preference test case

* fix: fixed issue to update email cadence for account notification type

* refactor: updated time

* fix: fixed mixed cadence issue

* fix: fixed border issue when no preferences

* refactor: refactor code

---------

Co-authored-by: sundasnoreen12 <[email protected]>
* fix: updated notifiations section url

* fix: updated test cases
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 64.47368% with 54 lines in your changes missing coverage. Please review.

Project coverage is 58.55%. Comparing base (515890d) to head (98e5154).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
src/notification-preferences/data/thunks.js 55.55% 14 Missing and 2 partials ⚠️
src/account-settings/data/service.js 0.00% 10 Missing and 1 partial ⚠️
...cation-preferences/NotificationCoursesDropdown.jsx 72.72% 5 Missing and 1 partial ⚠️
src/notification-preferences/data/service.js 16.66% 5 Missing ⚠️
src/account-settings/AccountSettingsPage.jsx 78.94% 4 Missing ⚠️
src/divider/Divider.jsx 0.00% 4 Missing ⚠️
...ation-preferences/NotificationPreferenceColumn.jsx 81.25% 3 Missing ⚠️
.../account-settings/delete-account/DeleteAccount.jsx 77.77% 1 Missing and 1 partial ⚠️
src/index.jsx 0.00% 1 Missing ⚠️
src/notification-preferences/data/actions.js 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   58.50%   58.55%   +0.04%     
==========================================
  Files         117      119       +2     
  Lines        2321     2413      +92     
  Branches      641      665      +24     
==========================================
+ Hits         1358     1413      +55     
- Misses        902      934      +32     
- Partials       61       66       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@awais-ansari awais-ansari changed the title 2u main feat: account level, email notification preferences and embargo feature Apr 15, 2025
@awais-ansari awais-ansari merged commit 397f688 into master Apr 16, 2025
8 checks passed
@awais-ansari awais-ansari deleted the 2u-main branch April 16, 2025 10:29
@awais-ansari awais-ansari restored the 2u-main branch April 29, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants