Skip to content

Conversation

@katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Apr 30, 2025

For all changes

https://2u-internal.atlassian.net/browse/ENT-10400

Display saved_for_later course enrollments in the learner profile view.

Screenshot 2025-04-30 at 7 54 48 AM

Testing Instructions:

  1. Navigate to a learner's profile view https://localhost.stage.edx.org:1991/aj-test-co/admin/people-management/learner-detail/5264635 and verify that you can see their courses that are saved for later.
  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 requested a review from a team April 30, 2025 14:55
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (88bf59f) to head (2ed7377).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...pleManagement/LearnerDetailPage/EnrollmentCard.jsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
- Coverage   87.07%   87.06%   -0.02%     
==========================================
  Files         694      694              
  Lines       15888    15890       +2     
  Branches     3300     3381      +81     
==========================================
  Hits        13835    13835              
+ Misses       1989     1982       -7     
- Partials       64       73       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@katrinan029 katrinan029 merged commit 65a545b into master Apr 30, 2025
7 of 9 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-10400 branch April 30, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants