Skip to content

feat: added product tour to notify all learners #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

sundasnoreen12
Copy link
Contributor

INF-1930

Description

This PR introduces a product tour for the newly added “Notify all learners” checkbox in both the Discussions MFE and the Discussion Sidebar.

The product tour is designed to highlight and explain the new checkbox feature.

Eligibility: The tour will only be shown to users with roles that have permission to view the checkbox.

Dismissal: Once the user acknowledges the tour, it will not appear again.

Content:

Title: "Let your learners know."

Body: "Check this box to notify all learners."

Feature Flag:
The tour is gated behind the same waffle flag "notifications.enable_post_notify_all_learners" that controls the checkbox.

Screenshots/sandbox (optional):

Screenshot 2025-07-02 at 6 10 06 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (7ebdf1b) to head (9ae6584).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   93.17%   93.24%   +0.06%     
==========================================
  Files         161      161              
  Lines        3414     3419       +5     
  Branches      925      921       -4     
==========================================
+ Hits         3181     3188       +7     
+ Misses        215      213       -2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sundasnoreen12 sundasnoreen12 requested review from awais-ansari, ayesha-waris and eemaanamir and removed request for awais-ansari July 2, 2025 13:39
@sundasnoreen12 sundasnoreen12 merged commit 3b7239d into master Jul 3, 2025
6 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1930 branch July 3, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants