-
Notifications
You must be signed in to change notification settings - Fork 81
feat: added captcha to discussion post creation #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 93.24% 93.57% +0.33%
==========================================
Files 161 162 +1
Lines 3419 3473 +54
Branches 926 941 +15
==========================================
+ Hits 3188 3250 +62
+ Misses 213 206 -7
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
308c93d
to
a6b1474
Compare
})); | ||
const data = await postComment(comment, threadId, parentId, enableInContextSidebar); | ||
const data = await postComment(comment, threadId, parentId, enableInContextSidebar, recaptchaToken); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a quick look while scanning PRs, I'm wondering why details like enableInContextSidebar
and recaptchaToken
are bleeding into the postComment
method signature. I realize only one of these are added here, but this don't feel appropriate to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @e0d,
Spam posts, comments, and responses have been appearing on the forum due to bots, so we've temporarily added a CAPTCHA to prevent this.
The enableInContextSidebar flag is used for event tracking on the backend.
src/discussions/post-comments/comments/comment/CommentEditor.jsx
Outdated
Show resolved
Hide resolved
src/discussions/post-comments/comments/comment/CommentEditor.jsx
Outdated
Show resolved
Hide resolved
0d9ac81
to
4360d6c
Compare
4360d6c
to
79fb8ec
Compare
216f046
to
f1768f8
Compare
f1768f8
to
1af495a
Compare
381e083
to
29b82ea
Compare
1db34e1
to
547f9cd
Compare
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or GitHub issues.
How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist