Skip to content

feat: added captcha to discussion post creation #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 17, 2025

Conversation

AhtishamShahid
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or GitHub issues.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@AhtishamShahid AhtishamShahid marked this pull request as draft July 15, 2025 08:09
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (8618e8c) to head (7db3f4a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   93.24%   93.57%   +0.33%     
==========================================
  Files         161      162       +1     
  Lines        3419     3473      +54     
  Branches      926      941      +15     
==========================================
+ Hits         3188     3250      +62     
+ Misses        213      206       -7     
+ Partials       18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sundasnoreen12 sundasnoreen12 marked this pull request as ready for review July 16, 2025 13:29
@sundasnoreen12 sundasnoreen12 force-pushed the ahtisham/captcha-implementation branch from 308c93d to a6b1474 Compare July 16, 2025 13:30
}));
const data = await postComment(comment, threadId, parentId, enableInContextSidebar);
const data = await postComment(comment, threadId, parentId, enableInContextSidebar, recaptchaToken);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a quick look while scanning PRs, I'm wondering why details like enableInContextSidebar and recaptchaToken are bleeding into the postComment method signature. I realize only one of these are added here, but this don't feel appropriate to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @e0d,
Spam posts, comments, and responses have been appearing on the forum due to bots, so we've temporarily added a CAPTCHA to prevent this.
The enableInContextSidebar flag is used for event tracking on the backend.

@sundasnoreen12 sundasnoreen12 enabled auto-merge (squash) July 17, 2025 06:27
@sundasnoreen12 sundasnoreen12 disabled auto-merge July 17, 2025 06:27
@sundasnoreen12 sundasnoreen12 force-pushed the ahtisham/captcha-implementation branch 5 times, most recently from 0d9ac81 to 4360d6c Compare July 17, 2025 08:44
@sundasnoreen12 sundasnoreen12 force-pushed the ahtisham/captcha-implementation branch from 4360d6c to 79fb8ec Compare July 17, 2025 09:10
@sundasnoreen12 sundasnoreen12 force-pushed the ahtisham/captcha-implementation branch 2 times, most recently from 216f046 to f1768f8 Compare July 17, 2025 11:48
@sundasnoreen12 sundasnoreen12 force-pushed the ahtisham/captcha-implementation branch from f1768f8 to 1af495a Compare July 17, 2025 11:57
@sundasnoreen12 sundasnoreen12 force-pushed the ahtisham/captcha-implementation branch from 381e083 to 29b82ea Compare July 17, 2025 12:18
@sundasnoreen12 sundasnoreen12 force-pushed the ahtisham/captcha-implementation branch from 1db34e1 to 547f9cd Compare July 17, 2025 13:14
@sundasnoreen12 sundasnoreen12 merged commit 2241575 into master Jul 17, 2025
6 checks passed
@sundasnoreen12 sundasnoreen12 deleted the ahtisham/captcha-implementation branch July 17, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants