fix: fixed email confirmation params issue #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
force-pushed
the
sundas/confirm-email
branch
from
5d64736 to
e22e465
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 93.75% 93.83% +0.08%
==========================================
Files 166 166
Lines 3618 3620 +2
Branches 973 973
==========================================
+ Hits 3392 3397 +5
+ Misses 210 207 -3
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awais-ansari
requested changes
Jul 23, 2025
|
|
||
| const addPost = useCallback(() => { | ||
| if (isEmailVerified) { dispatch(showPostEditor()); } else { openEmailConfirmation(); } | ||
| }, [isEmailVerified, openEmailConfirmation]); | ||
| if (!isEmailVerified && onlyVerifiedUsersCanPost) { openEmailConfirmation(); } else { dispatch(showPostEditor()); } |
There was a problem hiding this comment.
Both can be combined as a selector
awais-ansari
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-2037
Description
Fixed email confirmation checks issues
Merge Checklist
Post-merge Checklist