ConfirmEmailBanner is unintuitive and doesn't appear to be working as intended

[MaxFrank13]

When a user first creates an account and has not confirmed their email, a blue banner will appear at the top of the page:

The language of this banner implies that by clicking on the "Confirm Now" text the user will trigger a confirmation email to be sent to them.

Programmatically speaking, when this button is clicked, two things happen:

• a POST request is sent to the sendEmailUrl that is provided by the Learner Home init call
• a modal is opened with some additional information that feels somewhat misleading

However, the POST request is never actually made as the code is getting hung up on an error from the post utility function (source). This function expects a url and a body argument. The body is then stringified and send out with the POST request. Although, for this particular case, a body is never provided to the post utility function (source). This will throw an error as the stringify utility doesn't handle undefined values (source).

This can be replicated by creating a new account and clicking the “Confirm Now” button in the blue banner.

This can be fixed by forcing the post utility to always pass an empty object if no body argument is provided.

Although, the UX of the modal is still not very clear. It feels like it could mislead users into thinking that by clicking the red button in the modal, they have confirmed their email. It would be good to refactor the language here and perhaps the overall implementation of the modal to be more user-friendly.

[MaxFrank13]

Hey @mphilbrick211 👋 We are thinking this modal could use a bit of a tune up as the language is somewhat confusing and could potentially mislead learners into thinking they are confirming their email by clicking the red button in the modal. The only thing that happens when this button is clicked is that the modal and banner will disappear.

Would something like this require product review from AXIM? Our inclination is that we don't need product review for something that feels more like general clean up, even though this does involve a modification to something learners interact with.

[crathbun428]

@MaxFrank13 - My gut would be to say that yes, although this is more of a fix, it requires some thinking/review on what the fix is to the user facing experience. Curious to see what the changes to the language in the banner (if there is any) and the modal would look like.

cc: @mphilbrick211 and @jmakowski1123

[jmakowski1123]

Yeah, this is a gray area of a bug moving into an enhancement. Since there are direct changes being made to the UI, it should go through a light review.