Skip to content

chore: remove 'patch-package' and its unused frontend-build patch #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

bradenmacdonald
Copy link
Contributor

This reverts #1350 which added a patch to frontend-build to support a JS_CONFIG_FILEPATH env variable. I don't think it's used, but if 2U is still using this functionality, it's overdue to be merged into frontend-build instead of maintained on this patch.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 5, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (903fe28) to head (bcd03fe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1621   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         338      338           
  Lines        5726     5726           
  Branches     1382     1382           
=======================================
  Hits         5164     5164           
  Misses        545      545           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approved!

Let's wait a couple of days for somebody at 2U to give their ok before merging, though.

@bradenmacdonald bradenmacdonald requested a review from jansenk March 7, 2025 17:19
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Mar 14, 2025
@itsjeyd itsjeyd moved this from Needs Triage to Ready to Merge in Contributions Mar 14, 2025
@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 1, 2025
@bradenmacdonald
Copy link
Contributor Author

@jansenk @jristau1984 We never heard back from you on this PR - could you please take a look and confirm it won't negatively affect 2U if we merge? Thanks! Slack thread

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Apr 10, 2025
@arbrandes
Copy link
Contributor

@bradenmacdonald, do you mind rebasing this PR? I feel like we should go ahead and merge it. We can hash it out later if there are any downstream problems.

@jristau1984
Copy link
Contributor

Sorry, just seeing this after returning from an on-site last week. Yes, please feel free to merge this. 2U now has the Learning MFE on a private fork, so we are a bit more shielded from these kinds of changes now. Thanks!

@bradenmacdonald bradenmacdonald enabled auto-merge (rebase) April 15, 2025 18:52
@bradenmacdonald bradenmacdonald merged commit 756fbba into openedx:master Apr 15, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Contributions Apr 15, 2025
@openedx-webhooks openedx-webhooks removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Apr 15, 2025
@bradenmacdonald bradenmacdonald deleted the braden/remove-patch branch April 15, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants