Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidbar has non-preview links in preview mode #1657

Closed
feanil opened this issue Mar 26, 2025 · 0 comments · Fixed by #1660
Closed

Sidbar has non-preview links in preview mode #1657

feanil opened this issue Mar 26, 2025 · 0 comments · Fixed by #1660
Assignees
@KristinAoki
Labels
bug Report of or fix for something that isn't working as intended help wanted Ready to be picked up by anyone in the community

Comments

@feanil
Copy link
Contributor

feanil commented Mar 26, 2025 •
edited
Loading

The learning MFE now has a preview mode for learning content that is under the /preview/course... set of URLs. Both the sidebar and the breadcrumb view link to non preview urls.

eg. The link to the parent section is like
http://localhost:2000/course/course-v1:test+test+test/block-v1:test+test+test+type@sequential+block@bc0d339f753747d9b9fa162f59111673
instead of like
http://localhost:2000/preview/course/course-v1:test+test+test/block-v1:test+test+test+type@sequential+block@bc0d339f753747d9b9fa162f59111673

Image

Note: This is not a new bug, this was true in the old preview as well.
@feanil feanil added bug Report of or fix for something that isn't working as intended help wanted Ready to be picked up by anyone in the community labels Mar 26, 2025
@feanil feanil mentioned this issue Mar 26, 2025
Closed
@KristinAoki KristinAoki self-assigned this Mar 26, 2025
@KristinAoki KristinAoki mentioned this issue Mar 26, 2025
Merged
@KristinAoki KristinAoki linked a pull request Mar 26, 2025 that will close this issue
fix: breadcrumb and sidebar preview link #1660
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristinAoki KristinAoki

Labels
bug Report of or fix for something that isn't working as intended help wanted Ready to be picked up by anyone in the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: breadcrumb and sidebar preview link openedx/frontend-app-learning
2 participants
@feanil @KristinAoki