Skip to content

docs(oep-55): Only one group member needs to meet maintainer prereqs #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

kdmccormick
Copy link
Member

No description provided.

@feanil
Copy link
Contributor

feanil commented Mar 11, 2025

With this change I don't think #690 is necessary.

@kdmccormick kdmccormick merged commit aea29cb into openedx:master Mar 11, 2025
5 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/oep-55-groups branch March 11, 2025 15:28
@antoviaque
Copy link
Contributor

@kdmccormick @feanil Does that change mean that we will have maintainers, with the full merge privileges associated with it, which don't match the requirements from core contributors? Or would the "individual within the group" who is a proper core contributor be the one who has the merge rights, and is the actual "official" maintainer?

@kdmccormick
Copy link
Member Author

Does that change mean that we will have maintainers, with the full merge privileges associated with it, which don't match the requirements from core contributors?

No, this edit does not make any changes to how write access is granted to any repo. That is (and will remain to be) granted via the CC program with nomination and voting. I imagine any change to that would require a proper OEP review process.

Or would the "individual within the group" who is a proper core contributor be the one who has the merge rights

Yes, this.

and is the actual "official" maintainer

No--the group is the official maintainer. In order to be named a maintainer, the group must contain at least one member with write access (via the CC program).

The OEP, unmodified, already contained the idea that a "maintainer" may be a group rather than a single person. This edit is based on that idea.

@antoviaque
Copy link
Contributor

@kdmccormick Ah, I see, that makes sense - thanks for the details!

@robrap
Copy link
Contributor

robrap commented Mar 13, 2025

@kdmccormick: It is much simpler for a team to remain unblocked with 2 people, because both the reviewer and merger often require write access. I don't think 2 needs to be a requirement, but you could add a recommendation around this?

(Apologies, but I originally added this comment in a wiki page and not on this PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants