-
Notifications
You must be signed in to change notification settings - Fork 39
docs: OEP-49 Removed deprecated __init__.py section from oep-0049-django... #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ngo-app-patterns.rst
Thanks for the pull request, @mcfly-github! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! Have you filled out a signed contributor agreement? instructions. If you have, we might need to bump that process to see why the check is still failing.
@deborahgu It was not signed, that was the cause of the issue. I did it now. |
@mcfly-github once your CLA is processed, we can rerun the check and get this merged! Thank you 😁 |
@sarina You are welcome :) I'm looking for further issues. Let me know if you have an idea. |
@mcfly-github how about #681 ? That should be pretty straightforward. If you want something a bit more technical, how about openedx/docs.openedx.org#591 ? |
@sarina checking, thank you. |
Thanks for your first contribution @mcfly-github ! |
Removed the mentioned init.py section. Let me know if this task requiring further action.