Skip to content

docs: OEP-49 Removed deprecated __init__.py section from oep-0049-django... #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

mcfly-github
Copy link
Contributor

Removed the mentioned init.py section. Let me know if this task requiring further action.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 18, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 18, 2025

Thanks for the pull request, @mcfly-github!

This repository is currently maintained by @sarina.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 18, 2025
@sarina sarina linked an issue Mar 18, 2025 that may be closed by this pull request
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Have you filled out a signed contributor agreement? instructions. If you have, we might need to bump that process to see why the check is still failing.

@mcfly-github
Copy link
Contributor Author

looks good to me! Have you filled out a signed contributor agreement? instructions. If you have, we might need to bump that process to see why the check is still failing.

@deborahgu It was not signed, that was the cause of the issue. I did it now.

@sarina
Copy link
Contributor

sarina commented Mar 19, 2025

@mcfly-github once your CLA is processed, we can rerun the check and get this merged! Thank you 😁

@mcfly-github
Copy link
Contributor Author

mcfly-github commented Mar 19, 2025

@sarina You are welcome :) I'm looking for further issues. Let me know if you have an idea.

@sarina
Copy link
Contributor

sarina commented Mar 19, 2025

@mcfly-github how about #681 ? That should be pretty straightforward. If you want something a bit more technical, how about openedx/docs.openedx.org#591 ?

@mcfly-github
Copy link
Contributor Author

@sarina checking, thank you.

@sarina sarina changed the title docs: OEP-49 Removed deprecated __init__.py section from oep-0049-dja… docs: OEP-49 Removed deprecated __init__.py section from oep-0049-django Mar 22, 2025
@sarina sarina changed the title docs: OEP-49 Removed deprecated __init__.py section from oep-0049-django docs: OEP-49 Removed deprecated __init__.py section from oep-0049-django... Mar 25, 2025
@sarina sarina merged commit dfbcbb4 into openedx:master Mar 25, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Mar 25, 2025
@sarina
Copy link
Contributor

sarina commented Mar 25, 2025

Thanks for your first contribution @mcfly-github !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OEP-49 remove deprecated advice
4 participants