Skip to content

Commit 0daedf3

Browse files
refactor: addressing review comments
1 parent 8707785 commit 0daedf3

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

openedx_events/learning/data.py

+7-8
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class UserNonPersonalData:
2121
"""
2222

2323
id = attr.ib(type=int)
24-
is_active = attr.ib(type=bool, default=True)
24+
is_active = attr.ib(type=bool)
2525

2626

2727
@attr.s(frozen=True)
@@ -41,19 +41,18 @@ class UserPersonalData:
4141

4242

4343
@attr.s(frozen=True)
44-
class UserData:
44+
class UserData(UserNonPersonalData):
4545
"""
4646
Attributes defined for Open edX user object.
4747
48+
This class extends UserNonPersonalData to include PII data completing the
49+
user object.
50+
4851
Arguments:
49-
user_non_pii (UserNonPersonalData): user's Personal Identifiable
50-
Information.
51-
user_pii (UserPersonalData): user's Non Personal Identifiable
52-
Information.
52+
pii (UserPersonalData): user's Non Personal Identifiable Information.
5353
"""
5454

55-
user_non_pii = attr.ib(type=UserNonPersonalData)
56-
user_pii = attr.ib(type=UserPersonalData)
55+
pii = attr.ib(type=UserPersonalData)
5756

5857

5958
@attr.s(frozen=True)

0 commit comments

Comments
 (0)