-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0074] use linter for event code-annotations #448
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by @openedx/hooks-extension-framework. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
8b6706a
to
5b18728
Compare
This looks good to me, but I don't know this repo well (and am not a CC on it) so I can't provide an approving review. |
301842b
to
693efa6
Compare
897fef1
to
b8b3adf
Compare
b8b3adf
to
fb33e1f
Compare
I'll update this PR once #448 is merged! |
7715301
to
1e9fba5
Compare
Hey, @bmtcril: could you help me with a review here? :) Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR adds a linter for event code-annotations to raise quality errors when one required field is missing. This PR depends on:
openedx/edx-lint#478
Testing instructions
You can see it working here: https://github.com/openedx/openedx-events/actions/runs/12712053147/job/35436767992?pr=448#step:6:26
pylint openedx_events/learning/events.py
.pylint openedx_events/learning/events.py
once again.Deadline
None
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.