Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add an "open source contribution" label if a PR is being closed #276

Closed
nedbat opened this issue Nov 13, 2023 · 2 comments
Closed

Don't add an "open source contribution" label if a PR is being closed #276

nedbat opened this issue Nov 13, 2023 · 2 comments

Comments

@nedbat
Copy link
Contributor

nedbat commented Nov 13, 2023

This happens when we close an ex-edXer pull request. But we should never do it, because if the label should have been on the PR, it would have been added when it was opened.
@nedbat
Copy link
Contributor Author

nedbat commented Nov 13, 2023

Also, the bot is adding the pull request to the Contributions board.

nedbat pushed a commit that referenced this issue Dec 5, 2023
wip: assume a closed pr with no osc label is internal #276
094f153
nedbat pushed a commit that referenced this issue Dec 5, 2023
feat: assume a closed pr with no osc label is internal #276
15e0f1b
nedbat pushed a commit that referenced this issue Dec 7, 2023
@nedbat
feat: assume a closed pr with no osc label is internal #276
3f05749
@nedbat
Copy link
Contributor Author

nedbat commented Dec 7, 2023

Fixed in #284

@nedbat nedbat closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nedbat