-
Notifications
You must be signed in to change notification settings - Fork 83
Consolidate index.js + index.d.ts #3625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate index.js + index.d.ts #3625
Conversation
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v22 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
fd48e45
to
b9d2281
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-22.x #3625 +/- ##
================================================
+ Coverage 93.18% 93.39% +0.20%
================================================
Files 253 253
Lines 4743 4799 +56
Branches 1112 1075 -37
================================================
+ Hits 4420 4482 +62
+ Misses 320 310 -10
- Partials 3 7 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b9d2281
to
de51d56
Compare
@PKulkoRaccoonGang Would you be able to review this? @brian-smith-tcril I'm seeing a problem again where the lint check is failing (edit: it was a legitimate failure caused by changes in this PR, now fixed), but GitHub is showing the tests as passing. Seems to be the same issue as #3329 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once conflicts are resolved let's !
@brian-smith-tcril Thanks! I merged this, but accidentally made a typo in the squash commit message, so it starts with |
@bradenmacdonald I checked https://github.com/openedx/paragon/actions/runs/15472796847/job/43561207176 and it looks like semantic release is fine with it
I then made a sync 22 -> 23 PR (#3633) that resolved the conflicts in #3628 to see how commitlint handles it and it seems commitlint is not happy https://github.com/openedx/paragon/actions/runs/15478303670/job/43578949222?pr=3633
This isn't the first time we've had a commit that commitlint isn't happy about, it'll just lead to a couple commitlint failures until it makes it's way from 22 -> 23 -> next, but it won't trigger any unintentional releases or prevent any releases from being created. tl;dr - we'll see a couple commitlint CI failures on sync PRs but nothing will actually break. |
@brian-smith-tcril Thanks for checking, and sorry about that! :/ |
🎉 This PR is included in version 22.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
When I first added substantial TypeScript support to Paragon, I created an
src/index.d.ts
type declaration file that needs to be kept in sync with the "real"src/index.js
file. However, I realize now that there's a much simpler way to do this in a single file, although it requires adding a lot of@ts-ignore
comments where things haven't yet been converted to TypeScript.Note: it would be better to use
@ts-expect-error
because then it will warn us when we should remove those directives (i.e. when we try to ignore types that actually exist), but for some reason that's giving me an "unused expect-error" error, so I stuck with@ts-ignore
.Deploy Preview
TBD
Merge Checklist
n/a - no changes to components themselves
Post-merge Checklist