-
Notifications
You must be signed in to change notification settings - Fork 83
Adding missing aria label to Dropdown with Icon #3626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing aria label to Dropdown with Icon #3626
Conversation
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v22 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-22.x #3626 +/- ##
=============================================
Coverage 93.09% 93.09%
=============================================
Files 251 251
Lines 4592 4592
Branches 1038 1079 +41
=============================================
Hits 4275 4275
Misses 314 314
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks! I verified at https://deploy-preview-3626--paragon-openedx-v22.netlify.app/components/dropdown/#with-iconbutton that the |
🎉 This PR is included in version 22.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Adding aria label attribute to Dropdown with Icon.

#3616
Deploy Preview
https://paragon-openedx.netlify.app/components/dropdown/#with-iconbutton
Merge Checklist
example
app?Post-merge Checklist