Skip to content

margin-top on pgn__card-header-content feels too big when card has no logo image #3660

Closed as not planned
@brian-smith-tcril

Description

@brian-smith-tcril

With a logo the margin of calc(var(--pgn-spacing-spacer-base)*2) feels very reasonable, but without a logo it feels like there's quite a bit of extra space there

Image

Image

This looks mostly reasonable in this scenario, but it feels very odd on the new catalog MFE

Using the standard calc(var(--pgn-spacing-spacer-base)*2) margin:
Image

Overriding the margin to var(--pgn-spacing-spacer-base)
Image

It does seem as though the logo cuts about 1 --pgn-spacing-spacer-base down into the margin.

One potential issue with making the margin conditional and using a different margin for cards with logos vs cards without would be alignment when using some cards with logos and some without in a CardGrid.

I'd love to hear some design thoughts on this one!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions