Add failing test for heterogenous input periods with divide

Author: Morendil

openfisca_core/holders.py

@@ -330,6 +330,7 @@ def set_input_divide_by_period(holder, period, array):
         sub_period = period.start.period(cached_period_unit)
         while sub_period.start < after_instant:
             if holder.get_array(sub_period) is None:
+                print("*** set", holder.variable.name, sub_period, divided_array)
                 holder._set(sub_period, divided_array)
             sub_period = sub_period.offset(1)
     elif not (remaining_array == 0).all():

tests/core/test_simulation_builder.py

@@ -11,12 +11,13 @@
 from openfisca_core.tools import assert_near
 from openfisca_core.tools.test_runner import yaml
 from openfisca_core.entities import Entity, GroupEntity
+from openfisca_core.holders import set_input_divide_by_period
 from openfisca_core.populations import Population
 from openfisca_core.variables import Variable
 from openfisca_country_template.entities import Household
 from openfisca_country_template.situation_examples import couple
 from openfisca_core.errors import SituationParsingError
-from openfisca_core.periods import ETERNITY
+from openfisca_core.periods import ETERNITY, MONTH
 from openfisca_core.indexed_enums import Enum as OFEnum
 
 
@@ -87,9 +88,16 @@ def __init__(self):
 @fixture
 def persons():
     class TestPersonEntity(Entity):
+        def __init__(self, key, plural, label, doc):
+            super().__init__(key, plural, label, doc)
+            self.variables = {}
+
         def get_variable(self, variable_name):
-            result = TestVariable(self)
-            result.name = variable_name
+            result = self.variables.get(variable_name)
+            if result is None:
+                result = TestVariable(self)
+                result.name = variable_name
+                self.variables[variable_name] = result
             return result
 
         def check_variable_defined_for_entity(self, variable_name):
@@ -267,6 +275,21 @@ def test_finalize_person_entity(simulation_builder, persons):
     assert population.ids == ['Alicia', 'Javier']
 
 
+def test_heterogenous_periods(simulation_builder, persons):
+    persons_json = {'Alicia': {'salary': {'2018': 6000}}, 'Javier': {'salary': {'2018': 6000, '2018-01': 500}}}
+    simulation_builder.add_person_entity(persons, persons_json)
+    population = Population(persons)
+
+    salary = population.entity.get_variable('salary')
+    salary.definition_period = MONTH
+    salary.set_input = set_input_divide_by_period
+
+    simulation_builder.finalize_variables_init(population)
+    assert_near(population.get_holder('salary').get_array('2018-01'), [500, 500])
+    assert population.count == 2
+    assert population.ids == ['Alicia', 'Javier']
+
+
 def test_canonicalize_period_keys(simulation_builder, persons):
     persons_json = {'Alicia': {'salary': {'year:2018-01': 100}}}
     simulation_builder.add_person_entity(persons, persons_json)