Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFF product discrepancy #587

Closed
monsieurtanuki opened this issue May 25, 2024 · 7 comments
Closed

OFF product discrepancy #587

monsieurtanuki opened this issue May 25, 2024 · 7 comments

Comments

@monsieurtanuki
Copy link
Collaborator

What

I entered a price with Smoothie for product 7300400482844.
This product is recognized by Smoothie.
It's labeled "unknown" by the Prices web app.

Steps to reproduce the behavior:

  1. Go to https://prices.openfoodfacts.org/app/search
  2. Look for 7300400482844
  3. The product is unknown (but has prices)
  4. The product exists in OFF, though - https://fr.openfoodfacts.org/produit/7300400482844/wasa-tartine-croustillante-complet-260g

Expected behavior

The product should be found in OFF and displayed correctly in Prices.

Screenshots

image

@teolemon
Copy link
Member

There's a lag since we have a local copy of the db

@monsieurtanuki
Copy link
Collaborator Author

There's a lag since we have a local copy of the db

I can understand that, but it's not a new product (in the OFF db since April 2022) and it already had a price from 8 weeks ago.

@raphodn
Copy link
Member

raphodn commented May 26, 2024

the issue here is that the product is "obsolete"

image

Known problem, see this issue in the backend : openfoodfacts/open-prices#281 (we need to find a way to sync these products as well)

@monsieurtanuki
Copy link
Collaborator Author

Then there's a minor data problem in the OFF database as this "obsolete" product can be purchased today.

@serpico
Copy link

serpico commented May 27, 2024

Additionally, not all obsolete products seems to be handled the same.

  • 3414280971108 while obsolete in OFF is rendered fine in OP ( I bought it recently ).
  • 3596710430161 also obsolete in OFF ( with an additional withdrawal date ) is rendered partially in OP.

@monsieurtanuki
Copy link
Collaborator Author

For French people only...

Je propose qu'on fasse passer le champ obsolete en type perceval qui n'a qu'une seule valeur possible : "C'est pas faux !"
Source : https://m.facebook.com/allocine/videos/sc%C3%A8ne-culte-kaamelott/207254386821697/?locale=fr_FR

@raphodn
Copy link
Member

raphodn commented May 31, 2024

Closing in favor of the backend issue openfoodfacts/open-prices#281 👍

@raphodn raphodn closed this as completed May 31, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in 💸 Open Prices May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants