Skip to content

Folksonomy Engine loads CSS and a font from CDNs #9012

@hangy

Description

@hangy

@import url("https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.4/themes/redmond/jquery-ui.css");
@import url("https://rawgit.com/free-jqgrid/jqGrid/master/css/ui.jqgrid.css");
@import url("https://netdna.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css");

image

For ProductOpener itself, we usually try to reduce the dependency on 3rd party CDNs. folksonomy.js does the opposite by loading three files from three different CDNs.

  1. jQuery UI is already bundled with ProductOpener
  2. FontAwesome could be revisited, because ProductOpener now mostly seems to use Material Icons since the redesign
  3. Bundle jqGrid, or replace it (if there's feature parity) with other grid already bundled?

Code pointers

You can find some code pointers here. If some are missing, feel free to add them yourself in this file, or to ask them.

Part of

Metadata

Metadata

Assignees

No one assigned

    Labels

    ⭐ 🐛 top bugTop bug.⭐ top issueTop issue.CSSJavaScriptgood first issueWelcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help.🎯 P1🏷️ Folksonomy ProjectThe Folksonomy project allows to add custom data to product, and model non food products.

    Projects

    Status

    No status

    Status

    To discuss and validate

    Status

    Backlog

    Status

    To triage

    Status

    No status

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions