-
-
Notifications
You must be signed in to change notification settings - Fork 481
Open
Labels
Description
In Makefile, we have:
OS := $(shell uname)
[..]
ifeq ($(OS), Darwin)
export CPU_COUNT=$(shell sysctl -n hw.logicalcpu || echo 1)
else
export CPU_COUNT=$(shell nproc || echo 1)
endif
This fails on Windows because nproc is not available.
Instead we could use %NUMBER_OF_PROCESSORS% (it's unclear if those are physical or logical cores)
I'm not sure what's the returned value of uname is on Windows though, could someone test and add a condition on it so that we call this on Windows?
$(shell echo %NUMBER_OF_PROCESSORS%)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
To discuss and validate