Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we extend the Knowledge Panel system ? #623

Open
teolemon opened this issue Oct 17, 2024 · 2 comments
Open

How should we extend the Knowledge Panel system ? #623

teolemon opened this issue Oct 17, 2024 · 2 comments

Comments

@teolemon
Copy link
Member

Problem

  • We need to scale it to Open Beauty Facts, Open Pet Food Facts and Open Products Facts, beyond scaling it to labels, nutrients and categories. What should the directory structure look like ? opf/knowledge_panels/ or knowledge_panels/opf/
  • We need to make the system less fragile since people are translating keys that should not be translatable.

cc @raphael0202 @stephanegigandet

@stephanegigandet
Copy link
Contributor

  • We need to make the system less fragile since people are translating keys that should not be translatable.

Which keys?

@raphael0202
Copy link
Contributor

Which keys?

The value tag keys. But it's already taken care of, I've updated the schema so that keys are not translatable anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Status: To Discuss & Validate
Status: To do
Status: To Discuss & Validate
Development

No branches or pull requests

3 participants