Order Cycle search on BOM page is not working for more than 5 OCs

[tschumilas]

Description

On the BOM page, it is often necessary to limit the search to a particular order cycle. The drop down list of OCs on the BOM page is limited to 5 OCs. If you select 'all' and search by order cycle name, no orders in that OC are found. So users with more than 5 OCs cannot find orders using BOM easily.

Further - if you just search by date range to find orders - the orders from all order cycles are found, but there is a blank in the 'order cycle' field in the returned data, so the user cannot identify which OC the order is from.

Expected Behavior

User should be able to enter an order cycle name and find orders in this OC on the BOM page.

Actual Behaviour

It is only possible to search for 5 order cycles. The orders can be found - just by using a date range search. But then the OC name is not appearing in the search results. It is not possible to search and find all the orders in a given OC, if the user has more than 5 active OCs.

Users can easily have more than 5 OCs with active orders, especially if the set up an OC per pickup location, or use OC tagging for different customer groups....

Steps to Reproduce

Create more than 5 order cycles, with orders
Go to BOM and see that only 5 OCs show in the drop down
Search for your 6th OC name - and see the search does not return results
Search for 'all' OCs (or search by date range) and see that all the orders are listed,
See that the order from the 6th order cycle has a blank where the OC name should be in the search results.
1.
2.
3.
4.

Animated Gif/Screenshot

Here are my hub's order cycles for the past 90 days:

Here is the BOM page - showing only 5 of these OCs in the drop down

If I search using a date range, I capture the orders from the non-listed order cycles. But note that the oc name is missing (for those order cycles not in the drop down search list)

Workaround

Searching by date range returns the orders - but then the user needs to go to the order to see which OC it is from.

Severity

S3

bug-s1: a critical feature is broken: checkout, payments, signup, login
bug-s2: a non-critical feature is broken, no workaround
bug-s3: a feature is broken but there is a workaround
bug-s4: it's annoying, but you can use it
bug-s5: we can live with it, only a few users impacted

https://github.com/openfoodfoundation/openfoodnetwork/wiki/Bug-severity
-->

Your Environment

• Version used:
• Browser name and version:
• Operating System and version (desktop or mobile):

Possible Fix

There may not be 'room' to add all the OCs in the dropdown, but can it be possible to search by OC name?