Fix Rubocop Style issues

[dacook]

We use Rubocop to standardise our code, which can improve code quality and reduce confusion. When evaluating each rule, consider if it helps with those goals or not. Often the suggested autocorrection is fine, but some cops require more consideration and there may be a better solution, or it might be appropriate to disable them, rather than create unnecessary extra work.
If unsure, please ping @openfoodfoundation/developers in a github comment to request an opinion.

Strategy to fix issues

The normal process to fix a style issue is:

1. Choose a cop to work on, next on the list (but ⚠️ double check there isn't already a PR addressing rubocop that might conflict: https://github.com/openfoodfoundation/openfoodnetwork/pulls)
2. Remove it from .rubocop_todo.yml and run rubocop to see the error(s). Also check out this script.
3. Evaluate the rule, and consider applying the suggested fix if it makes sense
   • It may be helpful to commit some fixes separately, or chunked together
   • If it's not a simple fix, it may be worth simply adding a rubocop:disable comment in some cases (disable only offending line where possible)

When a cop or group of cops is complete, open a pull request.

Issues

Generated 4 Mar 2025:

• Style/ArrayIntersect
• Style/CaseEquality
• Style/ClassAndModuleChildren
• Style/FrozenStringLiteralComment
• Style/GlobalStdStream
• Style/HashConversion
• Style/HashEachMethods
• Style/MapToHash
• Style/MissingRespondToMissing
• Style/NestedModifier
• Style/OpenStructUse
• Style/OptionalBooleanParameter
• Style/PreferredHashMethods
• Style/RedundantArgument
• Style/RedundantAssignment
• Style/RedundantInitialize
• Style/ReturnNilInPredicateMethodDefinition
• Style/SlicingWithRange