Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return version with all statement #424

Open
Leobouloc opened this issue Aug 29, 2023 · 0 comments · May be fixed by #452
Open

Return version with all statement #424

Leobouloc opened this issue Aug 29, 2023 · 0 comments · May be fixed by #452
Assignees
@Leobouloc
Milestone
5.0

Comments

@Leobouloc
Copy link
Contributor

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.
As pointed out by @SergioSim in this comment , the xAPI spec requires that statements be returned with the API version:

Statements returned by an LRS MUST retain the version they are accepted with. If they lack a version, the version MUST be set to 1.0.0.

This is currently not the case
@Leobouloc Leobouloc mentioned this issue Aug 29, 2023
Merged
4 tasks
@Leobouloc Leobouloc self-assigned this Oct 5, 2023
@Leobouloc Leobouloc linked a pull request Oct 5, 2023 that will close this issue
Open
6 tasks
@wilbrdt wilbrdt added this to the 5.0 milestone Oct 13, 2023
@wilbrdt wilbrdt linked a pull request Oct 19, 2023 that will close this issue
[WIP] (api) Follow xAPI spec for versioning #452
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leobouloc Leobouloc

Labels
None yet
Projects
Ralph roadmap
Status: Todo
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

[WIP] (api) Follow xAPI spec for versioning openfun/ralph
2 participants
@Leobouloc @wilbrdt