You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After Pydantic 2.0 migration, the get function in src/ralph/api/routers/statements.py typing has different values for verb and activity. In addition to that, a block was added for later coercion of these fields, although it should not be necessary. It would be nice to tidy this up.
TODO:
Fix input type hints for verb and activities
Remove type coercion for verb and activities within get
Remove noqa: PLR0912 (too many branches)
Add test for IRI as input to backend query ?
The text was updated successfully, but these errors were encountered:
Leobouloc
changed the title
[Pydantic > 2] [API] Fix typing of verb and activity queries in get
[Pydantic > 2] [API] Fix IRI typing of verb and activity queries in getJan 24, 2024
Leobouloc
changed the title
[Pydantic > 2] [API] Fix IRI typing of verb and activity queries in get
[pydantic > 2] [API] Fix IRI typing of verb and activity queries in getJan 24, 2024
Feature Request
After Pydantic 2.0 migration, the
get
function insrc/ralph/api/routers/statements.py
typing has different values forverb
andactivity
. In addition to that, a block was added for later coercion of these fields, although it should not be necessary. It would be nice to tidy this up.TODO:
verb
andactivities
verb
andactivities
withinget
noqa: PLR0912
(too many branches)The text was updated successfully, but these errors were encountered: