Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pydantic > 2] [API] Fix IRI typing of verb and activity queries in get #556

Open
4 tasks
Leobouloc opened this issue Jan 24, 2024 · 0 comments
Open
4 tasks

Comments

@Leobouloc
Copy link
Contributor

Leobouloc commented Jan 24, 2024

Feature Request

After Pydantic 2.0 migration, the get function in src/ralph/api/routers/statements.py typing has different values for verb and activity. In addition to that, a block was added for later coercion of these fields, although it should not be necessary. It would be nice to tidy this up.

TODO:

  • Fix input type hints for verb and activities
  • Remove type coercion for verb and activities within get
  • Remove noqa: PLR0912 (too many branches)
  • Add test for IRI as input to backend query ?
@Leobouloc Leobouloc changed the title [Pydantic > 2] [API] Fix typing of verb and activity queries in get [Pydantic > 2] [API] Fix IRI typing of verb and activity queries in get Jan 24, 2024
@Leobouloc Leobouloc changed the title [Pydantic > 2] [API] Fix IRI typing of verb and activity queries in get [pydantic > 2] [API] Fix IRI typing of verb and activity queries in get Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant