-
-
Notifications
You must be signed in to change notification settings - Fork 252
OpenHab 3 -> Semantic Model: Items shoul appear in every group they are members of #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The model is necessarily constrained to only represent the physical organization of your model. Physically, it's impossible for a Point or Equipment to be in more than one location at the same time or to be a part or more than one equipment at the same time. It's physically impossible. If you violate this restriction, it destroys the computers ability to reason about the home automation. In short, the model is there to give the computer more information that it can use to reason about your home automation (e.g. to allow HABot to interpret the natural language "turn on all the lights in the living room"). If the assumption that the model represents the physical layout of the automation, that becomes impossible. Given this, your "DownOnSubset" Group doesn't make sense in the model. It's not a Location. It's not an Equipment. It's not a Point. It is a functional grouping. Functional groups are still allowed, of course. But they don't belong in the model. |
Well then were do functional groups belong? Groups a very helpful controlling your smart home. By using only the physical organization you are losing an really advanced smart home. |
Create them like any other Item that isn't necessarily a part of the model on the Items settings page. A Group that isn't part of the model is just a Group without a semantic tag. Again, I never said above that you can't have functional type Groups. They just don't belong in the model. Base on my own setup, only about 60% of all Items and Groups end up in the model. The model is not and never was intended to include everything. |
Yes a common misconception is that the Model view will show your groups and their members with fancy icons if they happen to have a Location or Equipment tag. (1) Well if you click the "show non-semantic" checkbox you'll get a mix of both... |
I'm going to add a second page to the Getting Started Tutorial to talk about Items that are not a part of the model. This misconception is just too common. |
The problem is, the items view is a simple confusing list. It is not suitable for a complex configuration. When you open your file explorer you don't have all your files in a simple list you have a structure. This should be used for your items as well. Does the "semantic model" has any functional effect on how openhab works with the items? I haven't seen anything yet but maybe it exists. If there is no functional effect then items should appear in any Group or Equipment or Location it is assigned to. As long as it is possible to add an item to more than on of those groups, equipments or locations it should be also displayed in each of those. Or you have to create the restriction that you can only add it to one Group or Equipment or Location.
Maybe the term "semantic model" is already a misconception. The name doesn't explain anything. |
That I agree with. When you have more than a couple dozen items, it just becomes a flat list that you only use to search for a particular item you know the name of. Which is the very purpose of keeping it around. |
As I mentioned, it's how HABot can understand what you mean when you say something like "turn on the lights in the living room" or "what's the temperature in the kitchen?". It also pretty much drives the automatically generated parts of the Overview Page. What get's shown on the Locations, Equipment, and Properties tabs is driven by the model. There are also some Actions that let you query for what type an Item is and determine where it fits in the semantic model (e.g. |
Ok, but then there should be either the restriction that an item could be the member of only one semantic model entry or, despite the fact that it is physically impossible to have one item in several rooms, it should be displayed in every semantic model entry where it is assigned to. Every thing else is simply confusing. |
It's all a big experiment. I'm guilty of being a big part of it. |
It don't think, that therefor a semantic model build on the physical organization is necessary. With a logical structure you have more possibilities. Instead of telling HABot: 'Turn on the lights in the living room' then 'Turn on the ceilling light in the kitchen' you could tell HABot simply: 'Turn on the default lights' or in my example it would be: 'Close DownOnSunset Shutters' instead of the two commands 'Close livingroom shutters' and 'Close bedroom shutters'. It would make everything much simpler for the user. Regarding the
You can do this as well. Just implement a check box where the user can decide if the item, equiptment or location should be included in the generated home page |
I think at a minimum this result of this discussion is that it's a feature request, not a bug. I've made some changes to the Getting Started Tutorial to emphasize that this is how the model works, include the restrictions, and added some instruction for how to manage Items outside of the model. The preview can be found at https://deploy-preview-1522--openhab-docs-preview.netlify.app/docs/tutorial/model.html (note that's been unreviewed, if you find anything wrong, unclear, or lacking please comment on the PR at. openhab/openhab-docs#1522 |
Yeah, I agree that it is a feature request 😊 Shall I close this one and file a new feature request? |
Would be solved by #2970 |
The problem
I have the following model:
FirstFloor
,ControlGroups
andDownOnSunset
are groups. As you can see, the shuttersBedroom
andLivingroom
are in the groupsFirstFloor
andDownOnSunset
but in the model the only are display in one of those groups. In which group can change when you modify one of those groups (e.g. by adding a new member).Expected behavior
Every item should be displayed in every group they are a member of. Even if this means that the item is more than once in this list.
Steps to reproduce
You will see, that the item is only display in one group. But how can you tell, that it is also in the second group? Only by selecting the group in the list, click on the Item on the right side of the screen and take a look at
Direct Group Members
Your environment
The text was updated successfully, but these errors were encountered: