Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key attestation in HAIP #119

Open
Sakurann opened this issue Nov 20, 2024 · 3 comments
Open

key attestation in HAIP #119

Sakurann opened this issue Nov 20, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@Sakurann
Copy link
Contributor

Key attestation has been added to OID4VCI.
How do we want to profile it in HAIP?
Do we want to mandate key_attestation proof type?

@Sakurann
Copy link
Contributor Author

Sakurann commented Dec 13, 2024

it looks like implementers are using both, suggest we change to the following

The wallet MUST support both the JWT proof type and attestation proof type. The Credential Issuer MUST support both.
When the JWT proof type is used, key_attestation proof type MUST be supported.

this would de facto mandate key attestation, but the issuer has a choice.

@Sakurann
Copy link
Contributor Author

as discussed in #32, we should discuss if we want to mandate any other JWT header parameter (jwk, x5c, trust_chain, in addition to key_attestation)

@tlodderstedt
Copy link
Contributor

I suggest to start by adding the key attestation methods mentioned above to HAIP. I would make both MTI for issuers and let the wallet choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants