Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "description" to list of fields that MAY be included in stream creation #186

Open
FragLegs opened this issue Jun 17, 2024 · 3 comments · May be fixed by #195
Open

Add "description" to list of fields that MAY be included in stream creation #186

FragLegs opened this issue Jun 17, 2024 · 3 comments · May be fixed by #195
Labels
spec:SSF v1Final Issues that must be fixed before we propose a spec to become a v1 final spec.

Comments

@FragLegs
Copy link
Contributor

In section 7.1.1.1, we say that the stream creation request MAY include any Receiver-supplied fields, and then we list events_requested and delivery. We should either include description as well, or remove the list and let implementers discover which fields are Receiver-supplied above in section 7.1.1 (the latter option being more future-proof if we add any other Receiver-supplied fields in later versions).
@tulshi
Copy link
Contributor

tulshi commented Jun 17, 2024

Seems reasonable. You haven't marked this for v3, so would you like this to be addressed right now, or after v3?

@FragLegs
Copy link
Contributor Author

It's not essential. We can wait until after v3, since it is just a clarity edit.

@FragLegs FragLegs linked a pull request Aug 12, 2024 that will close this issue
Open
@FragLegs
Copy link
Contributor Author

Pull this out of #195 into its own PR since it is a normative change

@FragLegs FragLegs added the v1Final Issues that must be fixed before we propose a spec to become a v1 final spec. label Jan 24, 2025
@tulshi tulshi linked a pull request Feb 11, 2025 that will close this issue
Minor clarity edits #195
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec:SSF v1Final Issues that must be fixed before we propose a spec to become a v1 final spec.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor clarity edits openid/sharedsignals
2 participants
@FragLegs @tulshi